Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: onboard @carbon/ibmdotcom-react to IBM Telemetry 🚀 #11507

Conversation

francinelucca
Copy link
Contributor

@francinelucca francinelucca commented Feb 8, 2024

Description

Adds config file and dependency necessary to start tracking telemetry data via IBM Telemetry

Changelog

New

Changed

  • Updates readme telemetry disclosure
  • Updates postinstall script to use IBM telemetry command
  • Include telemetry.yml in package.json files config

Removed

  • Removes @carbon/telemetry dependency

Review

Please look through telemetry.yml config file and ensure desired props/values have been captured. For more info see Telemetry Config Schema

PLEASE NOTE: In order for IBM Telemetry to start collecting data for these projects, a new build must be published including these changes.

@francinelucca francinelucca requested a review from a team as a code owner February 8, 2024 17:04
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2024

@kennylam kennylam changed the base branch from v1 to release/v1.55.0 February 8, 2024 19:09
@kennylam kennylam changed the base branch from release/v1.55.0 to v1 February 8, 2024 19:09
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @francinelucca!

@kennylam kennylam added package: react Work necessary for the Carbon for IBM.com react components package v1 Ready to merge Label for the pull requests that are ready to merge labels Feb 8, 2024
@francinelucca francinelucca changed the title chore: onboard @carbon/ibm-products v1 to IBM Telemetry 🚀 chore: onboard @carbon/ibmdotcom-react to IBM Telemetry 🚀 Feb 8, 2024
@francinelucca francinelucca force-pushed the chore/onboard-dotcom-react-to-ibm-telemetry branch from 327ff86 to b0a2557 Compare February 8, 2024 21:51
@kodiakhq kodiakhq bot merged commit 2bafbbd into carbon-design-system:v1 Feb 8, 2024
29 of 30 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Feb 9, 2024
…ign-system#11507)

Adds config file and dependency necessary to start tracking telemetry data via [IBM Telemetry](https://github.com/ibm-telemetry/telemetry-js)

**New**

- Adds @ibm/telemetry-js dependency
- Adds [telemetry.yml](packages/react/telemetry.yml) config file
    - This file was generated using [IBM Telemetry automated config generator](ibm-telemetry/telemetry-js-config-generator#1)

**Changed**

- Updates readme telemetry disclosure
- Updates postinstall script to use IBM telemetry command
- Include `telemetry.yml` in package.json files config

**Removed**

- Removes `@carbon/telemetry` dependency

Please look through [telemetry.yml](packages/react/telemetry.yml) config file and ensure desired props/values have been captured. For more info see [Telemetry Config Schema](https://github.com/ibm-telemetry/telemetry-config-schema?tab=readme-ov-file#jsx-scope)

**PLEASE NOTE:** In order for IBM Telemetry to start collecting data for these projects, a new build must be published including these changes.
kodiakhq bot pushed a commit that referenced this pull request Feb 9, 2024
…11512)

### Cherry-pick of 2bafbbd into v1 release branch `release/v1.55.0`.

Adds config file and dependency necessary to start tracking telemetry data via [IBM Telemetry](https://github.com/ibm-telemetry/telemetry-js)

**New**

- Adds @ibm/telemetry-js dependency
- Adds [telemetry.yml](packages/react/telemetry.yml) config file - This file was generated using [IBM Telemetry automated config generator](ibm-telemetry/telemetry-js-config-generator#1)

**Changed**

- Updates readme telemetry disclosure
- Updates postinstall script to use IBM telemetry command
- Include `telemetry.yml` in package.json files config

**Removed**

- Removes `@carbon/telemetry` dependency

Please look through [telemetry.yml](packages/react/telemetry.yml) config file and ensure desired props/values have been captured. For more info see [Telemetry Config Schema](https://github.com/ibm-telemetry/telemetry-config-schema?tab=readme-ov-file#jsx-scope)

**PLEASE NOTE:** In order for IBM Telemetry to start collecting data for these projects, a new build must be published including these changes.

### Related Ticket(s)

Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}

### Description

{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}

{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants