-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: onboard @carbon/ibmdotcom-react to IBM Telemetry 🚀 #11507
chore: onboard @carbon/ibmdotcom-react to IBM Telemetry 🚀 #11507
Conversation
Deploy preview created for package Built with commit: b0a25573a36fb2379bea97b9bf4c9556f5f6d281 |
Deploy preview created for package Built with commit: b0a25573a36fb2379bea97b9bf4c9556f5f6d281 |
Deploy preview created for package Built with commit: b0a25573a36fb2379bea97b9bf4c9556f5f6d281 |
Deploy preview created for package Built with commit: b0a25573a36fb2379bea97b9bf4c9556f5f6d281 |
Deploy preview created for package Built with commit: b0a25573a36fb2379bea97b9bf4c9556f5f6d281 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @francinelucca!
327ff86
to
b0a2557
Compare
…ign-system#11507) Adds config file and dependency necessary to start tracking telemetry data via [IBM Telemetry](https://github.com/ibm-telemetry/telemetry-js) **New** - Adds @ibm/telemetry-js dependency - Adds [telemetry.yml](packages/react/telemetry.yml) config file - This file was generated using [IBM Telemetry automated config generator](ibm-telemetry/telemetry-js-config-generator#1) **Changed** - Updates readme telemetry disclosure - Updates postinstall script to use IBM telemetry command - Include `telemetry.yml` in package.json files config **Removed** - Removes `@carbon/telemetry` dependency Please look through [telemetry.yml](packages/react/telemetry.yml) config file and ensure desired props/values have been captured. For more info see [Telemetry Config Schema](https://github.com/ibm-telemetry/telemetry-config-schema?tab=readme-ov-file#jsx-scope) **PLEASE NOTE:** In order for IBM Telemetry to start collecting data for these projects, a new build must be published including these changes.
…11512) ### Cherry-pick of 2bafbbd into v1 release branch `release/v1.55.0`. Adds config file and dependency necessary to start tracking telemetry data via [IBM Telemetry](https://github.com/ibm-telemetry/telemetry-js) **New** - Adds @ibm/telemetry-js dependency - Adds [telemetry.yml](packages/react/telemetry.yml) config file - This file was generated using [IBM Telemetry automated config generator](ibm-telemetry/telemetry-js-config-generator#1) **Changed** - Updates readme telemetry disclosure - Updates postinstall script to use IBM telemetry command - Include `telemetry.yml` in package.json files config **Removed** - Removes `@carbon/telemetry` dependency Please look through [telemetry.yml](packages/react/telemetry.yml) config file and ensure desired props/values have been captured. For more info see [Telemetry Config Schema](https://github.com/ibm-telemetry/telemetry-config-schema?tab=readme-ov-file#jsx-scope) **PLEASE NOTE:** In order for IBM Telemetry to start collecting data for these projects, a new build must be published including these changes. ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description {{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}} {{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}} ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Description
Adds config file and dependency necessary to start tracking telemetry data via IBM Telemetry
Changelog
New
Changed
telemetry.yml
in package.json files configRemoved
@carbon/telemetry
dependencyReview
Please look through telemetry.yml config file and ensure desired props/values have been captured. For more info see Telemetry Config Schema
PLEASE NOTE: In order for IBM Telemetry to start collecting data for these projects, a new build must be published including these changes.