Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react): remove react wrappers #11502

Conversation

IgnacioBecerra
Copy link
Contributor

Related Ticket(s)

Closes #11501

Description

This PR removes React wrapper build scripts, React as a dependency, and the @storybook/addon-knob dep as it is not used.

Changelog

Removed

  • react wrapper build script files
  • @storybook/addon-knobs dependency

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 7, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2024

@kennylam
Copy link
Member

kennylam commented Feb 8, 2024

@IgnacioBecerra nice! I was just about to do this 😂. Can we also update the docs?

Change these 2 sections:

To maybe something like:

This package can also be used within other JavaScript frameworks such as Angular and
Vue. This is achievable since web components are the modern browser standard, and
work well with other front-end frameworks that exist in the application. In
turn, this also comes with the benefits of encapsulation within the Shadow DOM:

Remove these files:

Remove these entire sections:

@IgnacioBecerra
Copy link
Contributor Author

@kennylam knew i was missing something here or there, updated!

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam merged commit 3545094 into carbon-design-system:feat/cwc-storybook-7-vite Feb 13, 2024
8 of 13 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
* chore(react): remove react wrapper

* chore(deps): remove uneeded deps

* fix(react): remove more react stuff
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
* chore(react): remove react wrapper

* chore(deps): remove uneeded deps

* fix(react): remove more react stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants