Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pagination): update story to Storybook v7 #11401

Merged
merged 4 commits into from
Jan 18, 2024
Merged

feat(pagination): update story to Storybook v7 #11401

merged 4 commits into from
Jan 18, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Jan 12, 2024 •
edited
Loading

Related Ticket(s)

Closes #11334

Description

Adjustments to pagination component stories to be compatible with Storybook v7.

Changelog

Changed

  • Updated pagination Storybook stories for Storybook v7
  • Specify page-input-disabled attribute of cds-pagination as boolean

@m4olivei m4olivei requested a review from a team as a code owner January 12, 2024 14:31
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11401/index.html

Built with commit: 2a30bd2d80fb84db6ded6d089941420c6e01f506

RichKummer
RichKummer reviewed Jan 17, 2024
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @m4olivei , this is looking good, just found a few issues in the controls for Playground:

  1. backwardText does not update the tooltip for that icon button (but forwardText works fine)
Screenshot 2024-01-17 at 2 23 50 PM
  1. The pageInputDisabled attribute does not seem to be working like the react version.

@m4olivei
Copy link
Contributor Author

Nice catches @RichKummer ! Turns out those are issues on the main branch as well. They are simple fixes, so I've fixed them here in the most recent two commits.

RichKummer
RichKummer approved these changes Jan 17, 2024
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great @m4olivei ! Thanks for jumping on the change 🔥

ariellalgilmore
ariellalgilmore approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam merged commit 7a3a48f into carbon-design-system:feat/cwc-storybook-7-vite Jan 18, 2024
5 of 11 checks passed
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11401/index.html

Built with commit: 2a30bd2d80fb84db6ded6d089941420c6e01f506

kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@m4olivei @kennylam
feat(pagination): update story to Storybook v7 (carbon-design-system#…
991681c 
…11401)

* chore(pagination): update pagination stories to sb v7

* fix(pagination): fix backward-text control

* fix(pagination): specify page-input-disabled property as boolean

---------

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@RichKummer RichKummer RichKummer approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components storybook-7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m4olivei @ibmdotcom-bot @RichKummer @ariellalgilmore @kennylam