Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[number-input]: incorrect readOnly styles #11390

Closed
kennylam opened this issue Jan 11, 2024 · 0 comments · Fixed by #11402
Closed

[number-input]: incorrect readOnly styles #11390

kennylam opened this issue Jan 11, 2024 · 0 comments · Fixed by #11402
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@kennylam
Copy link
Member

The read only control styling is a little off, the buttons keep the border strong, but we would expect the border to be the same as the border under the number. Please refer to the number input style page for the correct token color
Screenshot 2024-01-08 at 3 38 20 PM

Originally posted by @oliviaflory in #11336 (review)
@kennylam kennylam added bug Something isn't working dev Needs some dev work package: carbon web components labels Jan 11, 2024
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Jan 11, 2024
@kennylam kennylam mentioned this issue Jan 11, 2024
Merged
@ko1ebayev ko1ebayev mentioned this issue Jan 12, 2024
Merged
@ariellalgilmore ariellalgilmore moved this from Backlog to Review in Carbon for IBM.com Jan 18, 2024
@kodiakhq kodiakhq bot closed this as completed in #11402 Jan 19, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 19, 2024
@ko1ebayev
fix(number-input): fix incorrect controls border for readonly mode (#…
3b2149b 
…11402)

### Related Ticket(s)

Closes #11390 

### Description

Fixed incorrect controls styles for readonly number input

### Changelog

**New**

- added some styles
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Jan 19, 2024
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 12, 2024
@ko1ebayev @kennylam
fix(number-input): fix incorrect controls border for readonly mode (c…
5e3e2ad 
…arbon-design-system#11402)

### Related Ticket(s)

Closes carbon-design-system#11390 

### Description

Fixed incorrect controls styles for readonly number input

### Changelog

**New**

- added some styles
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@ko1ebayev
fix(number-input): fix incorrect controls border for readonly mode (c…
fab300d 
…arbon-design-system#11402)

### Related Ticket(s)

Closes carbon-design-system#11390 

### Description

Fixed incorrect controls styles for readonly number input

### Changelog

**New**

- added some styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(number-input): fix incorrect controls border for readonly mode ko1ebayev/carbon-for-ibm-dotcom
2 participants
@kennylam @ariellalgilmore