is-selectable on DataTable does not set selection-name prop on table rows #11349
Closed
2 tasks done
Assignees
Labels
Comments
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 31, 2024
### Related Ticket(s) Closes #11349 ### Description To use Selection on DataTable, the documentation states that just need to add the `is-selectable` property in the cds-table tag and setting the prop will automatically set a numerical `selection-name` attribute to every row. This does not happen. ### Changelog **Changed** - Updated the selection functionality to check if `is-selectable` property set to the DataTable, and if so to add `selection-name` property to the rows. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
m4olivei
pushed a commit
to m4olivei/carbon-for-ibm-dotcom
that referenced
this issue
Feb 1, 2024
…sign-system#11449) ### Related Ticket(s) Closes carbon-design-system#11349 ### Description To use Selection on DataTable, the documentation states that just need to add the `is-selectable` property in the cds-table tag and setting the prop will automatically set a numerical `selection-name` attribute to every row. This does not happen. ### Changelog **Changed** - Updated the selection functionality to check if `is-selectable` property set to the DataTable, and if so to add `selection-name` property to the rows. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Jun 11, 2024
…sign-system#11449) ### Related Ticket(s) Closes carbon-design-system#11349 ### Description To use Selection on DataTable, the documentation states that just need to add the `is-selectable` property in the cds-table tag and setting the prop will automatically set a numerical `selection-name` attribute to every row. This does not happen. ### Changelog **Changed** - Updated the selection functionality to check if `is-selectable` property set to the DataTable, and if so to add `selection-name` property to the rows. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
To use Selection on DataTable, the documentation states that just need to add the
is-selectableproperty in thecds-tabletag and "Setting the prop will automatically set a numerical selection-name attribute to every row".This does not work, you have to manually add a
selection-nameattribute to every row yourself if you want the check box to appear on each row.Component(s) impacted
DataTable
Browser
Firefox
Carbon for IBM.com version
v2/latest
Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Application/website
Various tools for UK Labs
Package
@carbon/web-components
CodeSandbox example
n/a
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: