Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stackblitz): versions pointing to v2 #11277

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix(stackblitz): versions pointing to v2 #11277

merged 2 commits into from
Jan 3, 2024

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Dec 27, 2023 •
edited
Loading

Related Ticket(s)

Closes #none

Description

fixes examples to point to v2 cdn's and stackblitz folder

Changelog

Changed

  • v1 -> v2
  • codesandbox folder -> stackblitz folder

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner December 27, 2023 23:55
@ariellalgilmore ariellalgilmore requested review from kennylam and sangeethababu9223 and removed request for a team December 27, 2023 23:55
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 28, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11277/index.html

Built with commit: bc6eaeb6cde794d0c922545ca6a26ec8786ac3ef

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 28, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11277/index.html

Built with commit: bc6eaeb6cde794d0c922545ca6a26ec8786ac3ef

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 28, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11277/index.html

Built with commit: bc6eaeb6cde794d0c922545ca6a26ec8786ac3ef

annawen1
annawen1 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Jan 2, 2024
@ariellalgilmore ariellalgilmore merged commit bd01c71 into carbon-design-system:main Jan 3, 2024
10 of 20 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/stackblitz-version-tag branch January 3, 2024 15:43
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@ariellalgilmore @kennylam
fix(stackblitz): versions pointing to v2 (carbon-design-system#11277)
38c922a 
* fix(stackblitz): versions pointing to v2

* fix(stackblitz): Links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariellalgilmore @ibmdotcom-bot @annawen1