Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video-player): v2 alignment #11145

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

none

Description

looks like some v2 changes accidentally effected the video-player alignment. This should bring it back centered

before:
Screenshot 2023-11-14 at 9 32 39 AM
after:
Screenshot 2023-11-14 at 9 38 17 AM

Changelog

Changed

  • set padding to 0

@ariellalgilmore ariellalgilmore added package: web components Work necessary for the IBM.com Library web components package v2 labels Nov 14, 2023
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner November 14, 2023 17:39
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 14, 2023

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 14, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 14, 2023

@ariellalgilmore ariellalgilmore merged commit fa1a414 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Nov 14, 2023
3 of 14 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/video-player-v2-alignment branch November 14, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants