chore(masthead-v2): merge dev into main #11131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem#10389) * chore(gh): remove auto assignees * chore(checks): pin node version to 18.15
…ystem#10352) * chore(project): remove unneeded package.json entries * chore(gh): clean up ci-check workflow * chore(actions): disable react ci-checks for now
### Description A current [bug](nodejs/node#47563) in the latest version of Node is causing CI checks to fail. The bug has been fixed but not yet back-ported, so in the meantime will test pinning the version to `18.15`. ### Changelog **New** - {{new thing}} **Changed** - pin `ci-check` workflow Node version to `18.15` **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
### Related Ticket(s) carbon-design-system#9093 carbon-design-system#8814 ### Description This PR introduces the parallelization feature for Cypress testing. The work for this PR consisted in creating a IBM Cloud CodeEngine instance out of an image provided by the sorry-cypress service, especifically the `sorry-cypress-director` service. The Director instance is the one who controls what tests each machine should run, coming from the same spec file run. In order to achieve parallelization among the newly created machine matrix, we are now using the `cy2` dependency, which intercepts the parallelization call made to Cypress Dashboard and redirects all the data to our CE instance. However, in order to speed things up and ensure each machine doesn't need to install and build every time, we separate the workflow into separate pieces: 1. Install job - Install dependencies - Cache dependencies - Build storybook - Upload `storybook` artifacts 2. Run tests - Retrieve cached dependencies - Retrieve `storybook` artifacts - Run tests - If one test fails, create a `failure.txt` file and upload as artifact 3. Check if all tests passed - Wait until all tests finish - Retrieve `failure.txt` artifact - If said file exists, fail this job The caching and artifact uploading ensures that each of the test jobs don't need to install/rebuild everything all over again. With this setup, that should only happen once, speeding up the rest of the jobs. ### Changelog **New** - introduced parallelization **Changed** - `e2e-tests.yml` file <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…esign-system#10399) Bumps [andstor/file-existence-action](https://github.com/andstor/file-existence-action) from 1 to 2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/andstor/file-existence-action/releases">andstor/file-existence-action's releases</a>.</em></p> <blockquote> <h2>v2.0.0</h2> <h3>Changed</h3> <ul> <li>Updated to the node16 runtime by default</li> <li>Deprecates the <code>allow_failure</code> variable in favor of <code>fail</code></li> </ul> <h3>Fixed</h3> <ul> <li>Updated usage of deprecated <a href="https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/"><code>set-output</code></a> command</li> </ul> <h2>v1.1.0</h2> <h3>Added</h3> <ul> <li>Support for glob patterns.</li> </ul> <h2>v1.0.1</h2> <h3>Added</h3> <ul> <li>Checks for existence of files and directories specified in input variables.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/andstor/file-existence-action/commit/20b4d2e596410855db8f9ca21e96fbe18e12930b"><code>20b4d2e</code></a> Correct input name</li> <li><a href="https://github.com/andstor/file-existence-action/commit/31359852f5f601604498353d20d704b27b0ed556"><code>3135985</code></a> Deprecates the "allow_failure" variable in favor of "fail"</li> <li><a href="https://github.com/andstor/file-existence-action/commit/bbb27a8d0c6ffc98910d37d692fa50392dc7af64"><code>bbb27a8</code></a> Merge pull request <a href="https://redirect.github.com/andstor/file-existence-action/issues/113">#113</a> from hbiede/patch-1</li> <li><a href="https://github.com/andstor/file-existence-action/commit/e6b07c7c8a57a08145b72dd11ebfd6bae5c80b6e"><code>e6b07c7</code></a> Update dependencies</li> <li><a href="https://github.com/andstor/file-existence-action/commit/6b4f78425eea38eb1aa2c9829bc8489e8e5f0f03"><code>6b4f784</code></a> Fix typo</li> <li><a href="https://github.com/andstor/file-existence-action/commit/ef72eba3eb7eff4045c574f384fde5688298eee8"><code>ef72eba</code></a> Updated to the node16 runtime by default</li> <li><a href="https://github.com/andstor/file-existence-action/commit/c492e43713b59c0534dd9183abd6afca1a03e4a9"><code>c492e43</code></a> Merge pull request <a href="https://redirect.github.com/andstor/file-existence-action/issues/106">#106</a> from DaSchTour/patch-1</li> <li><a href="https://github.com/andstor/file-existence-action/commit/afdfb059cd6d9659012341dec72fb8b9c7be8624"><code>afdfb05</code></a> Update to node16</li> <li>See full diff in <a href="https://github.com/andstor/file-existence-action/compare/v1...v2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
[](https://renovatebot.com) This PR contains the following updates: | Update | Change | |---|---| | lockFileMaintenance | All locks refreshed | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
…arbon-design-system#10410) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@carbon/pictograms-react](https://togithub.com/carbon-design-system/carbon) | [`11.41.0` -> `11.42.0`](https://renovatebot.com/diffs/npm/@carbon%2fpictograms-react/11.41.0/11.42.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>carbon-design-system/carbon</summary> ### [`v11.42.0`](https://togithub.com/carbon-design-system/carbon/compare/9d9c35494255b0ad0996bad46ffaf093cdd20012...75f69e49161bf54184d4392c3d48115f852dc8fc) [Compare Source](https://togithub.com/carbon-design-system/carbon/compare/9d9c35494255b0ad0996bad46ffaf093cdd20012...75f69e49161bf54184d4392c3d48115f852dc8fc) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42My4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjMuMSJ9-->
…system#10398) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update default runtime to node16 (<a href="https://redirect.github.com/actions/upload-artifact/issues/293">#293</a>)</li> <li>Update package-lock.json file version to 2 (<a href="https://redirect.github.com/actions/upload-artifact/issues/302">#302</a>)</li> </ul> <h3>Breaking Changes</h3> <p>With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12.</p> <h2>v2.3.1</h2> <p>Fix for empty fails on Windows failing on upload <a href="https://redirect.github.com/actions/upload-artifact/issues/281">#281</a></p> <h2>v2.3.0 Upload Artifact</h2> <ul> <li>Optimizations for faster uploads of larger files that are already compressed</li> <li>Significantly improved logging when there are chunked uploads</li> <li>Clarifications in logs around the upload size and prohibited characters that aren't allowed in the artifact name or any uploaded files</li> <li>Various other small bugfixes & optimizations</li> </ul> <h2>v2.2.4</h2> <ul> <li>Retry on HTTP 500 responses from the service</li> </ul> <h2>v2.2.3</h2> <ul> <li>Fixes for proxy related issues</li> </ul> <h2>v2.2.2</h2> <ul> <li>Improved retryability and error handling</li> </ul> <h2>v2.2.1</h2> <ul> <li>Update used actions/core package to the latest version</li> </ul> <h2>v2.2.0</h2> <ul> <li>Support for artifact retention</li> </ul> <h2>v2.1.4</h2> <ul> <li>Add Third Party License Information</li> </ul> <h2>v2.1.3</h2> <ul> <li>Use updated version of the <code>@action/artifact</code> NPM package</li> </ul> <h2>v2.1.2</h2> <ul> <li>Increase upload chunk size from 4MB to 8MB</li> <li>Detect case insensitive file uploads</li> </ul> <h2>v2.1.1</h2> <ul> <li>Fix for certain symlinks not correctly being identified as directories before starting uploads</li> </ul> <h2>v2.1.0</h2> <ul> <li>Support for uploading artifacts with multiple paths</li> <li>Support for using exclude paths</li> <li>Updates to dependencies</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/0b7f8abb1508181956e8e162db84b466c27e18ce"><code>0b7f8ab</code></a> ci(github): update action/download-artifact from v1 to v3 (<a href="https://redirect.github.com/actions/upload-artifact/issues/312">#312</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/013d2b89baa2f354c5ffec54c68bec4ab39a2534"><code>013d2b8</code></a> Create devcontainer for codespaces + update all dev dependencies (<a href="https://redirect.github.com/actions/upload-artifact/issues/375">#375</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/055b8b3f04a4a7ed853f2c6ab04256f83e4874dc"><code>055b8b3</code></a> Bump Actions NPM dependencies (<a href="https://redirect.github.com/actions/upload-artifact/issues/374">#374</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/7a5d4831f75130126bffffb8443b412485f7b836"><code>7a5d483</code></a> ci(github): update action/checkout from v2 to v3 (<a href="https://redirect.github.com/actions/upload-artifact/issues/315">#315</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/e0057a5b76f2fdad976135e8dd7b691e632b9056"><code>e0057a5</code></a> README: Bump actions/checkout to v3 (<a href="https://redirect.github.com/actions/upload-artifact/issues/352">#352</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/7fe6c13ac83e8572a115d6d5e45afc880cc4fe7e"><code>7fe6c13</code></a> Update to latest <code>actions/publish-action</code> (<a href="https://redirect.github.com/actions/upload-artifact/issues/363">#363</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/83fd05a356d7e2593de66fc9913b3002723633cb"><code>83fd05a</code></a> Bump actions-core to v1.10.0 (<a href="https://redirect.github.com/actions/upload-artifact/issues/356">#356</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/3cea5372237819ed00197afe530f5a7ea3e805c8"><code>3cea537</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/327">#327</a> from actions/robherley/artifact-1.1.0</li> <li><a href="https://github.com/actions/upload-artifact/commit/849aa7758a428ee22be38de371b49c8bd57c4b9d"><code>849aa77</code></a> nvm use 12 & npm run release</li> <li><a href="https://github.com/actions/upload-artifact/commit/4d3986961d0423ba9a593efb490a2960eb65f43b"><code>4d39869</code></a> recompile with correct ncc version</li> <li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…0418) ### Description Merge latest release into main. ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…em#10408) ### Related Ticket(s) Followup to carbon-design-system#10342 ### Description This change fixes a bug in which the table of contents is not properly positioned along with the L0/L1 masthead menus > **Note** > Because the stickyHeader is a globally-scoped utility and could be initialized by _any_ component that imports it, we'll need to cherry-pick this PR's commit to the `feat/masthead-v2-dev` branch so the `main` branch components and the `feat/masthead-v2` branch components aren't causing race conditions https://user-images.githubusercontent.com/25532785/235171270-8da551b7-54d5-46ff-afea-f1acb3d19bf5.mov Direct link to deploy preview testing page: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10408/iframe.html?knob-Masthead%20Version=L1&id=components-dotcom-shell--without-shell&viewMode=story ### Changelog **Changed** - Updates table-of-contents/stickyHeader integration
…esign-system#10227) * fix(video-player): account for video players in shadowroots * fix(video-player): update tabs-extended-media example * fix(video-player): support environments without getRootNode method --------- Co-authored-by: Putra Bonaccorsi <[email protected]> Co-authored-by: kennylam <[email protected]> Co-authored-by: John Kaeser <[email protected]>
…tem#10421) * chore(doc): update notice cohoice documentation * chore(refactor): refactor notice choice * feat: generate react element * Update packages/web-components/src/components/notice-choice/__stories__/README.stories.mdx Co-authored-by: Anna Wen <[email protected]> --------- Co-authored-by: Anna Wen <[email protected]> Co-authored-by: Ariella Gilmore <[email protected]>
* Update lerna.json * Update lerna.json
- @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected]
…system#10423) * chore(gh): remove auto assignee from issue templates (carbon-design-system#10389) * chore(gh): remove auto assignees * chore(checks): pin node version to 18.15 * chore(project): remove unneeded package.json entries (carbon-design-system#10352) * chore(project): remove unneeded package.json entries * chore(gh): clean up ci-check workflow * chore(actions): disable react ci-checks for now * chore(checks): pin node version to 18.15 (carbon-design-system#10390) ### Description A current [bug](nodejs/node#47563) in the latest version of Node is causing CI checks to fail. The bug has been fixed but not yet back-ported, so in the meantime will test pinning the version to `18.15`. ### Changelog **New** - {{new thing}} **Changed** - pin `ci-check` workflow Node version to `18.15` **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * feat(e2e): introducing parallelization (carbon-design-system#10314) ### Related Ticket(s) carbon-design-system#9093 carbon-design-system#8814 ### Description This PR introduces the parallelization feature for Cypress testing. The work for this PR consisted in creating a IBM Cloud CodeEngine instance out of an image provided by the sorry-cypress service, especifically the `sorry-cypress-director` service. The Director instance is the one who controls what tests each machine should run, coming from the same spec file run. In order to achieve parallelization among the newly created machine matrix, we are now using the `cy2` dependency, which intercepts the parallelization call made to Cypress Dashboard and redirects all the data to our CE instance. However, in order to speed things up and ensure each machine doesn't need to install and build every time, we separate the workflow into separate pieces: 1. Install job - Install dependencies - Cache dependencies - Build storybook - Upload `storybook` artifacts 2. Run tests - Retrieve cached dependencies - Retrieve `storybook` artifacts - Run tests - If one test fails, create a `failure.txt` file and upload as artifact 3. Check if all tests passed - Wait until all tests finish - Retrieve `failure.txt` artifact - If said file exists, fail this job The caching and artifact uploading ensures that each of the test jobs don't need to install/rebuild everything all over again. With this setup, that should only happen once, speeding up the rest of the jobs. ### Changelog **New** - introduced parallelization **Changed** - `e2e-tests.yml` file <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * chore(deps): bump andstor/file-existence-action from 1 to 2 (carbon-design-system#10399) Bumps [andstor/file-existence-action](https://github.com/andstor/file-existence-action) from 1 to 2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/andstor/file-existence-action/releases">andstor/file-existence-action's releases</a>.</em></p> <blockquote> <h2>v2.0.0</h2> <h3>Changed</h3> <ul> <li>Updated to the node16 runtime by default</li> <li>Deprecates the <code>allow_failure</code> variable in favor of <code>fail</code></li> </ul> <h3>Fixed</h3> <ul> <li>Updated usage of deprecated <a href="https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/"><code>set-output</code></a> command</li> </ul> <h2>v1.1.0</h2> <h3>Added</h3> <ul> <li>Support for glob patterns.</li> </ul> <h2>v1.0.1</h2> <h3>Added</h3> <ul> <li>Checks for existence of files and directories specified in input variables.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/andstor/file-existence-action/commit/20b4d2e596410855db8f9ca21e96fbe18e12930b"><code>20b4d2e</code></a> Correct input name</li> <li><a href="https://github.com/andstor/file-existence-action/commit/31359852f5f601604498353d20d704b27b0ed556"><code>3135985</code></a> Deprecates the "allow_failure" variable in favor of "fail"</li> <li><a href="https://github.com/andstor/file-existence-action/commit/bbb27a8d0c6ffc98910d37d692fa50392dc7af64"><code>bbb27a8</code></a> Merge pull request <a href="https://redirect.github.com/andstor/file-existence-action/issues/113">#113</a> from hbiede/patch-1</li> <li><a href="https://github.com/andstor/file-existence-action/commit/e6b07c7c8a57a08145b72dd11ebfd6bae5c80b6e"><code>e6b07c7</code></a> Update dependencies</li> <li><a href="https://github.com/andstor/file-existence-action/commit/6b4f78425eea38eb1aa2c9829bc8489e8e5f0f03"><code>6b4f784</code></a> Fix typo</li> <li><a href="https://github.com/andstor/file-existence-action/commit/ef72eba3eb7eff4045c574f384fde5688298eee8"><code>ef72eba</code></a> Updated to the node16 runtime by default</li> <li><a href="https://github.com/andstor/file-existence-action/commit/c492e43713b59c0534dd9183abd6afca1a03e4a9"><code>c492e43</code></a> Merge pull request <a href="https://redirect.github.com/andstor/file-existence-action/issues/106">#106</a> from DaSchTour/patch-1</li> <li><a href="https://github.com/andstor/file-existence-action/commit/afdfb059cd6d9659012341dec72fb8b9c7be8624"><code>afdfb05</code></a> Update to node16</li> <li>See full diff in <a href="https://github.com/andstor/file-existence-action/compare/v1...v2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> * chore(deps): lock file maintenance (carbon-design-system#10411) [](https://renovatebot.com) This PR contains the following updates: | Update | Change | |---|---| | lockFileMaintenance | All locks refreshed | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> * chore(deps): update dependency @carbon/pictograms-react to v11.42.0 (carbon-design-system#10410) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@carbon/pictograms-react](https://togithub.com/carbon-design-system/carbon) | [`11.41.0` -> `11.42.0`](https://renovatebot.com/diffs/npm/@carbon%2fpictograms-react/11.41.0/11.42.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>carbon-design-system/carbon</summary> ### [`v11.42.0`](https://togithub.com/carbon-design-system/carbon/compare/9d9c35494255b0ad0996bad46ffaf093cdd20012...75f69e49161bf54184d4392c3d48115f852dc8fc) [Compare Source](https://togithub.com/carbon-design-system/carbon/compare/9d9c35494255b0ad0996bad46ffaf093cdd20012...75f69e49161bf54184d4392c3d48115f852dc8fc) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42My4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjMuMSJ9--> * chore(deps): bump actions/upload-artifact from 2 to 3 (carbon-design-system#10398) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update default runtime to node16 (<a href="https://redirect.github.com/actions/upload-artifact/issues/293">#293</a>)</li> <li>Update package-lock.json file version to 2 (<a href="https://redirect.github.com/actions/upload-artifact/issues/302">#302</a>)</li> </ul> <h3>Breaking Changes</h3> <p>With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12.</p> <h2>v2.3.1</h2> <p>Fix for empty fails on Windows failing on upload <a href="https://redirect.github.com/actions/upload-artifact/issues/281">#281</a></p> <h2>v2.3.0 Upload Artifact</h2> <ul> <li>Optimizations for faster uploads of larger files that are already compressed</li> <li>Significantly improved logging when there are chunked uploads</li> <li>Clarifications in logs around the upload size and prohibited characters that aren't allowed in the artifact name or any uploaded files</li> <li>Various other small bugfixes & optimizations</li> </ul> <h2>v2.2.4</h2> <ul> <li>Retry on HTTP 500 responses from the service</li> </ul> <h2>v2.2.3</h2> <ul> <li>Fixes for proxy related issues</li> </ul> <h2>v2.2.2</h2> <ul> <li>Improved retryability and error handling</li> </ul> <h2>v2.2.1</h2> <ul> <li>Update used actions/core package to the latest version</li> </ul> <h2>v2.2.0</h2> <ul> <li>Support for artifact retention</li> </ul> <h2>v2.1.4</h2> <ul> <li>Add Third Party License Information</li> </ul> <h2>v2.1.3</h2> <ul> <li>Use updated version of the <code>@action/artifact</code> NPM package</li> </ul> <h2>v2.1.2</h2> <ul> <li>Increase upload chunk size from 4MB to 8MB</li> <li>Detect case insensitive file uploads</li> </ul> <h2>v2.1.1</h2> <ul> <li>Fix for certain symlinks not correctly being identified as directories before starting uploads</li> </ul> <h2>v2.1.0</h2> <ul> <li>Support for uploading artifacts with multiple paths</li> <li>Support for using exclude paths</li> <li>Updates to dependencies</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/0b7f8abb1508181956e8e162db84b466c27e18ce"><code>0b7f8ab</code></a> ci(github): update action/download-artifact from v1 to v3 (<a href="https://redirect.github.com/actions/upload-artifact/issues/312">#312</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/013d2b89baa2f354c5ffec54c68bec4ab39a2534"><code>013d2b8</code></a> Create devcontainer for codespaces + update all dev dependencies (<a href="https://redirect.github.com/actions/upload-artifact/issues/375">#375</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/055b8b3f04a4a7ed853f2c6ab04256f83e4874dc"><code>055b8b3</code></a> Bump Actions NPM dependencies (<a href="https://redirect.github.com/actions/upload-artifact/issues/374">#374</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/7a5d4831f75130126bffffb8443b412485f7b836"><code>7a5d483</code></a> ci(github): update action/checkout from v2 to v3 (<a href="https://redirect.github.com/actions/upload-artifact/issues/315">#315</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/e0057a5b76f2fdad976135e8dd7b691e632b9056"><code>e0057a5</code></a> README: Bump actions/checkout to v3 (<a href="https://redirect.github.com/actions/upload-artifact/issues/352">#352</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/7fe6c13ac83e8572a115d6d5e45afc880cc4fe7e"><code>7fe6c13</code></a> Update to latest <code>actions/publish-action</code> (<a href="https://redirect.github.com/actions/upload-artifact/issues/363">#363</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/83fd05a356d7e2593de66fc9913b3002723633cb"><code>83fd05a</code></a> Bump actions-core to v1.10.0 (<a href="https://redirect.github.com/actions/upload-artifact/issues/356">#356</a>)</li> <li><a href="https://github.com/actions/upload-artifact/commit/3cea5372237819ed00197afe530f5a7ea3e805c8"><code>3cea537</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/327">#327</a> from actions/robherley/artifact-1.1.0</li> <li><a href="https://github.com/actions/upload-artifact/commit/849aa7758a428ee22be38de371b49c8bd57c4b9d"><code>849aa77</code></a> nvm use 12 & npm run release</li> <li><a href="https://github.com/actions/upload-artifact/commit/4d3986961d0423ba9a593efb490a2960eb65f43b"><code>4d39869</code></a> recompile with correct ncc version</li> <li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> * chore(release): merge release/v1.46.0 to main (carbon-design-system#10418) ### Description Merge latest release into main. ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * fix(sticky-header): table-of-contents positioning (carbon-design-system#10408) ### Related Ticket(s) Followup to carbon-design-system#10342 ### Description This change fixes a bug in which the table of contents is not properly positioned along with the L0/L1 masthead menus > **Note** > Because the stickyHeader is a globally-scoped utility and could be initialized by _any_ component that imports it, we'll need to cherry-pick this PR's commit to the `feat/masthead-v2-dev` branch so the `main` branch components and the `feat/masthead-v2` branch components aren't causing race conditions https://user-images.githubusercontent.com/25532785/235171270-8da551b7-54d5-46ff-afea-f1acb3d19bf5.mov Direct link to deploy preview testing page: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10408/iframe.html?knob-Masthead%20Version=L1&id=components-dotcom-shell--without-shell&viewMode=story ### Changelog **Changed** - Updates table-of-contents/stickyHeader integration * fix(video-player): account for video players in shadowroots (carbon-design-system#10227) * fix(video-player): account for video players in shadowroots * fix(video-player): update tabs-extended-media example * fix(video-player): support environments without getRootNode method --------- Co-authored-by: Putra Bonaccorsi <[email protected]> Co-authored-by: kennylam <[email protected]> Co-authored-by: John Kaeser <[email protected]> * Nc web component documentation update and refactor (carbon-design-system#10421) * chore(doc): update notice cohoice documentation * chore(refactor): refactor notice choice * feat: generate react element * Update packages/web-components/src/components/notice-choice/__stories__/README.stories.mdx Co-authored-by: Anna Wen <[email protected]> --------- Co-authored-by: Anna Wen <[email protected]> Co-authored-by: Ariella Gilmore <[email protected]> * chore(settings): update settings to v1.47.0 * Update lerna.json (carbon-design-system#10431) * Update lerna.json * Update lerna.json * Update lerna.json (carbon-design-system#10433) * chore(release): publish - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] --------- Co-authored-by: kennylam <[email protected]> Co-authored-by: Ignacio Becerra <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Putra Bonaccorsi <[email protected]> Co-authored-by: kennylam <[email protected]> Co-authored-by: John Kaeser <[email protected]> Co-authored-by: sanjitbauli <[email protected]> Co-authored-by: Anna Wen <[email protected]> Co-authored-by: Ariella Gilmore <[email protected]> Co-authored-by: ibmdotcom-bot <[email protected]> Co-authored-by: Carbon for IBM.com Bot <[email protected]>
…on-design-system#10442) ### Description Temporarily remove `notice-choice` React wrapper added in carbon-design-system#10421 as it is throwing errors and affecting the CI workflow. @sanjitbauli Since there is still a current React version this doesn't need to be any sort of blocker. Once it is fixed we can re-enable it. ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - `notice-choice` React wrapper <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…on-design-system#10442) (carbon-design-system#10444) ### Description Temporarily remove `notice-choice` React wrapper added in carbon-design-system#10421 as it is throwing errors and affecting the CI workflow. ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - `notice-choice` React wrapper <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> ### Related Ticket(s) {{Provide url(s) to the related ticket(s) that this pull request addresses}} ### Description {{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}} {{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}} ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
- @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected]
…#10475) ### Related Ticket(s) ### Description This PR should fix failing unit tests, allowing the `ci-check` job to complete successfully. ### Changelog **Changed** - fix unit tests
…ign-system#10469) * chore(notice-choice): remove react wrapper causing build errors (carbon-design-system#10442) ### Description Temporarily remove `notice-choice` React wrapper added in carbon-design-system#10421 as it is throwing errors and affecting the CI workflow. @sanjitbauli Since there is still a current React version this doesn't need to be any sort of blocker. Once it is fixed we can re-enable it. ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - `notice-choice` React wrapper <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * feat(table-of-contents): add self-filtering functionality * feat(table-of-contents): optionally filter out subtrees --------- Co-authored-by: Carbon for IBM.com Bot <[email protected]> Co-authored-by: kennylam <[email protected]> Co-authored-by: John Kaeser <[email protected]>
- @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected]
…#10917) (carbon-design-system#10956) ### Description Cherry pick of carbon-design-system#10917 for patch release. ### Changelog **New** - A new web component to create a notice & choice user interface. **Changed** - Notice and Choice content loaded by languages. - Set the default language to English. - Gain access to the hidden email and phone fields. **Removed** - Postal option removed from new notice and choice version <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description {{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}} {{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}} ### Changelog **New** - {{new thing}} **Changed** - {{changed thing}} **Removed** - {{removed thing}} <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…carbon-design-system#10914) Co-authored-by: kennylam <[email protected]>
…m#10998) * feat(masthead-v2): put container in document flow * feat(masthead-v2): format code * feat(masthead-v2): update height on resize * feat(masthead-v2): accurately describe observer * feat(masthead-v2): debounce resize observer callback * feat(masthead-v2): execute callback once after successive resizes --------- Co-authored-by: Andy Blum <[email protected]>
…tem#11085) * feat(masthead-v2): contact link should not affect CM_APP This has the potential to clobber the global app instance, preventing it from opening or closing altogether. * feat(masthead-v2): minimize CMApp on megamenu open * feat(masthead-v2): close chat module on L1 dropdown open * feat(masthead-v2): toggle masthead-contact label on cm-app state change * feat(masthead-contact): update cm-app event listeners * fix(masthead-contact): revert to hostlistener usage * fix(masthead-contact): remove console logs --------- Co-authored-by: Andy Blum <[email protected]>
jkaeser
requested review from
kennylam and
IgnacioBecerra
and removed request for
a team
jkaeser
added
package: web components
|
Deploy preview created for package Built with commit: 7baadd95d070b258cecb1bde65b2e327611f5395 |
|
Deploy preview created for package Built with commit: 7baadd95d070b258cecb1bde65b2e327611f5395 |
|
Deploy preview created for package Built with commit: 7baadd95d070b258cecb1bde65b2e327611f5395 |
|
Deploy preview created for package Built with commit: 7baadd95d070b258cecb1bde65b2e327611f5395 |
andy-blum
approved these changes
Nov 14, 2023
](https://renovatebot.com){kind=link}
There was a problem hiding this comment.
Verified that this PR contains the following work:
- ✅ ADCMS-4152 Update interaction with contact module
- ✅ ADCMS-4159 Use more explicit references within shadow root
- ✅ ADCMS-3667 optimize masthead to lower DOM node count
- ✅ ADCMS-3689 L1 Navigation v2 creates arrows on the side if there are no links configured
- ✅ ADCMS-4025 Make dds-masthead-container take up space
IgnacioBecerra
merged commit 00c33c6
into
carbon-design-system:feat/masthead-v2
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the latest from
feat/masthead-v2-devintofeat/masthead-v2so we can cut a new alpha release.