Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-group): v2 style updates #11007

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #10753

Description

Style issues with Content Group Component in V2

Changelog

Changed

  • Used Card Component instead of CTA Link
  • Style updated to match the latest

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 5, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 5, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 5, 2023

@sangeethababu9223 sangeethababu9223 linked an issue Oct 5, 2023 that may be closed by this pull request
@IgnacioBecerra IgnacioBecerra added package: web components Work necessary for the IBM.com Library web components package Needs design approval PRs on feature requests and new components have to get design approval before merge. v2 labels Oct 5, 2023
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oliviaflory
Copy link
Contributor

Thanks @sangeethababu9223 !

There seems to be a slight difference between the v1 and v2 examples when I add the children elements. In v2 the content items extend beyond the width of the content group, this might have more to do with the content item than the content group? But I am not quite sure. I know @kennylam is still working on the content item

We do want the content group to be able to accept 8 or 12 column children, similar the content section updates, so I am OK with merging this AS-IS for now and returning to it once we have more of the content components figured out.

V1
Screenshot 2023-10-13 at 6 44 03 AM

V2
Screenshot 2023-10-13 at 6 42 32 AM

V1
Screenshot 2023-10-13 at 6 49 08 AM

V2
Screenshot 2023-10-13 at 6 49 38 AM

Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sangeethababu9223 , two other things to add to Olivia's comment above:

  1. When nesting content items into content group, the top and bottom margins should merge together. But right now, it looks like the spacing values stack instead. @kennylam and @IgnacioBecerra were solving a similar problem recently, so they may have some insight.

You can see in the following screenshots that the margin spacing is stacking rather than merging together:
Screenshot 2023-10-30 at 11 38 01 AM
Screenshot 2023-10-30 at 11 38 12 AM

  1. The last update is that the last nested piece of content inside content group should automatically remove the bottom spacing (or merge it) so that there is 48px spacing between the bottom of the last item and the CTA.

You can see in the following screenshot that the spacing stacks, creating more space at the end than intended.
Screenshot 2023-10-30 at 11 39 18 AM

@sangeethababu9223
Copy link
Member Author

sangeethababu9223 commented Nov 6, 2023

Hey @RichKummer ,
I'ver fixed the margin collapse issue and the extra spacing before the CTA. Please check.

@oliviaflory,
Width difference in certain sections for V1 & V2 versions seems to be fixed with the update in content Item style. Please let me know if there is any issues.

Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @sangeethababu9223 !

@kennylam kennylam merged commit 94e9d94 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Nov 7, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs design approval PRs on feature requests and new components have to get design approval before merge. package: web components Work necessary for the IBM.com Library web components package v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] Content group
6 participants