Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table-of-contents): TOC scroll-behavior style typo #10982

Merged
merged 10 commits into from
Oct 11, 2023
Merged

fix(table-of-contents): TOC scroll-behavior style typo #10982

merged 10 commits into from
Oct 11, 2023

Conversation

marcelojcs
Copy link
Contributor

@marcelojcs marcelojcs commented Sep 28, 2023 •
edited by m4olivei
Loading

Related Ticket(s)

Closes #10493
Jira https://jsw.ibm.com/browse/ADCMS-3701

Description

Fixed the typo in the table-of-contents from scroll-behaviour: smooth; to scroll-behavior: smooth;

Changelog

Changed

changed the mistyping: scroll-behaviour: smooth; to scroll-behavior: smooth; in the "table-of-contents" component.

@marcelojcs marcelojcs requested a review from a team as a code owner September 28, 2023 14:38
@marcelojcs marcelojcs mentioned this pull request Sep 28, 2023
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 28, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10982/index.html

Built with commit: b2fbce5f13e2173d81ab8ca1b8822f65b882ed2f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 28, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10982/index.html

Built with commit: b2fbce5f13e2173d81ab8ca1b8822f65b882ed2f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 28, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10982/index.html

Built with commit: b2fbce5f13e2173d81ab8ca1b8822f65b882ed2f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 28, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10982/index.html

Built with commit: b2fbce5f13e2173d81ab8ca1b8822f65b882ed2f

@andy-blum andy-blum self-requested a review September 29, 2023 16:37
andy-blum
andy-blum approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@andy-blum andy-blum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good to me. not sure what's up with these tests right now

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Oct 3, 2023
@kennylam
Copy link
Member

kennylam commented Oct 3, 2023

code changes look good to me. not sure what's up with these tests right now

The prettier format checks are failing. @marcelojcs run a yarn format from project root and it should fix it.

@m4olivei
Copy link
Contributor

m4olivei commented Oct 4, 2023 •
edited
Loading

@kennylam I fixed the prettier issue. My read on the remaining CI failures is its the usuall mix of persistently failing things in all the places. I believe we are good to go here. Thanks!

@kennylam
Copy link
Member

kennylam commented Oct 5, 2023

@m4olivei Great, thanks!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 10, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10982/index.html

Built with commit: b2fbce5f13e2173d81ab8ca1b8822f65b882ed2f

@kodiakhq kodiakhq bot merged commit 1ec4866 into carbon-design-system:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-blum andy-blum andy-blum approved these changes

@kennylam kennylam kennylam approved these changes

@m4olivei m4olivei m4olivei approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TOC bug]: TOC un-smooth scroll behavior
5 participants
@marcelojcs @ibmdotcom-bot @kennylam @m4olivei @andy-blum