Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(masthead-a11y): None of the descendent elements with menuitem role is tabbable #10897

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Fix(masthead-a11y): None of the descendent elements with menuitem role is tabbable #10897

merged 5 commits into from
Oct 11, 2023

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #9691

Description

None of the descendent elements with menuitem role is tabbable

Changelog

Changed

  • Moved "menuitem" role from "li" element to "a" element

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner August 30, 2023 12:04
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 30, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10897/index.html

Built with commit: faad314617ae4da216b976b209b0c9946ec30fbb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 30, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10897/index.html

Built with commit: faad314617ae4da216b976b209b0c9946ec30fbb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 30, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10897/index.html

Built with commit: faad314617ae4da216b976b209b0c9946ec30fbb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 30, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10897/index.html

Built with commit: faad314617ae4da216b976b209b0c9946ec30fbb

IgnacioBecerra
IgnacioBecerra approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IgnacioBecerra IgnacioBecerra added package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge labels Oct 9, 2023
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10897/index.html

Built with commit: faad314617ae4da216b976b209b0c9946ec30fbb

@kodiakhq kodiakhq bot merged commit 3e5034f into carbon-design-system:main Oct 11, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Masthead A11Y]: None of the descendent elements with "menuitem" role is tabbable
4 participants
@sangeethababu9223 @ibmdotcom-bot @IgnacioBecerra @kennylam