Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer (new component) #1892

Open
3 tasks
Tracked by #1629
theetrain opened this issue Jan 14, 2024 · 3 comments
Open
3 tasks
Tracked by #1629

Layer (new component) #1892

theetrain opened this issue Jan 14, 2024 · 3 comments
Labels
enhancement New feature or request v11 Carbon v11 feature
Milestone
v1.0.0

Comments

@theetrain
Copy link
Collaborator

theetrain commented Jan 14, 2024 •
edited
Loading

Spun off from #1629
@theetrain theetrain added enhancement New feature or request breaking changes labels Jan 14, 2024
@theetrain theetrain added this to the v1.0.0 milestone Jan 14, 2024
@theetrain theetrain mentioned this issue Jan 14, 2024
Merged
@SimpleProgrammingAU
Copy link
Contributor

I don't think the light prop should be removed in v11. The React library has it marked for removal in v12, doesn't it?

@theetrain
Copy link
Collaborator Author

theetrain commented Jan 20, 2024 •
edited
Loading

You're right that the React component has it deprecated; probably to ease into its removal when Layer became available, but not because of forthcoming v12 styles. We should follow a similar backwards-compatibility cadence:

https://github.com/carbon-design-system/carbon/blob/be888a850730d9658decaf1336f4b3175eb4d817/packages/react/src/components/TextInput/TextInput.tsx#L84-L90

I updated the criteria above.

@theetrain theetrain added v11 Carbon v11 feature and removed breaking changes labels Jan 20, 2024
@theetrain theetrain mentioned this issue Jan 20, 2024
Open
SimpleProgrammingAU pushed a commit to SimpleProgrammingAU/carbon-components-svelte that referenced this issue Mar 9, 2024
Initial pass at Layer (new component) carbon-design-system#1892
f349b50
metonym pushed a commit that referenced this issue Mar 23, 2024
@SimpleProgrammingAU
feat(layer): first pass at Layer component (#1932)
180f33b 
Closes #1892
metonym pushed a commit that referenced this issue Mar 23, 2024
@SimpleProgrammingAU @metonym
feat(layer): first pass at Layer component (#1932)
5031d0b 
Closes #1892
@SimpleProgrammingAU
Copy link
Contributor

What are the outstanding tasks following the merge of PR #1932?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v11 Carbon v11 feature
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@SimpleProgrammingAU @theetrain