Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Calendar 5.7 #6

Closed
xyz1123581321 opened this issue Jun 2, 2021 · 13 comments
Closed

Full Calendar 5.7 #6

xyz1123581321 opened this issue Jun 2, 2021 · 13 comments

Comments

@xyz1123581321
Copy link

Can we get an update for FullCalendar 5.7 version?

@fansaien
Copy link
Collaborator

fansaien commented Jun 2, 2021

The FullCalendar supports rrule now. Before that, I did the rrule on my side. So, I need to do more tests. But, I will update it.

@fansaien
Copy link
Collaborator

fansaien commented Jun 4, 2021

In the new version, only the Premium plan can support the Timeline View and Vertical Resource View. I can not update it for now.

@fansaien fansaien closed this as completed Jun 4, 2021
@xyz1123581321
Copy link
Author

will there be an update for FullCalendar 6^?

@LukeTowers
Copy link
Contributor

@xyz1123581321 I'm planning on adding FullCalendar 6 to Winter CMS: wintercms/winter#970

@xyz1123581321
Copy link
Author

@LukeTowers that will be really nice built-in feature!

@xyz1123581321
Copy link
Author

@LukeTowers do you maybe know why the calendar isnt refreshing the records on filter update?

@fansaien
Copy link
Collaborator

will there be an update for FullCalendar 6^?

I will update it to FullCalendar 6.1

@xyz1123581321
Copy link
Author

Oh that would also be nice! How long will it take? Do you need any help?
Current version, Im not sure but I think $(document).on('ajaxComplete', this.proxy(this.onFilterUpdate)); is not triggered on Filter "Apply" button, and it does not filter right away, you either need to refresh or update calendar widget.

@LukeTowers
Copy link
Contributor

@xyz1123581321 if you're interested in contributing I'd welcome the help on the Winter PR 😉

@fansaien
Copy link
Collaborator

@xyz1123581321 I plan to do that may be next week or after next week.
For the onFilterUpdate, please review this: 94b815a
If the framework.js changed, you need to update the parameters.

@xyz1123581321
Copy link
Author

@LukeTowers I would love to! Let me see to manage my time! Thank you!
@fansaien I tried with ajax:request-complete, still it doesnt update the events. Will check other things.

this.migratejQueryEvent(document, 'ajax:request-complete', 'ajaxComplete', ['context', 'data', 'responseCode', 'xhr']);

key: "notifyApplicationRequestComplete",
    value: function notifyApplicationRequestComplete(data, responseCode, xhr) {
      return (0,_util__WEBPACK_IMPORTED_MODULE_6__.dispatch)('ajax:request-complete', {
        target: this.triggerEl,
        detail: {
          context: this.context,
          data: data,
          responseCode: responseCode,
          xhr: xhr
        }
      });
    }

@xyz1123581321
Copy link
Author

@fansaien did you test it if it is updating when filtering? I tried different things, still not working, currently I'm redrawing the calendar partial

@fansaien
Copy link
Collaborator

Yes, it is working on my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants