-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRR@10=0.35 not achieved on fine-tuning monoBERT task #200
Comments
Hi @d1shs0ap, thanks for helping to replicate. The link to the two config file seems to be broken, would u mind paste them into the issue? Also which commit are we using? Thanks! |
Hey @crystina-z, updated the config screenshots. The commit that I ran the experiments on is |
Hi @crystina-z, any updates on this issue? |
hi @d1shs0ap sorry for the waiting, it took a long while for me to realize that it's missing one line to specify the Thanks again for pointing this issue out! |
Ok great thanks, I'll test it out now! |
Hey @crystina-z the experiment just finished, here are the results:
Should I run the experiment again, with the latest commits? |
hi @d1shs0ap that would be nice. tho before that could u share the config file and command you used to run the scripts, just in case I missed anything there. |
@crystina-z Here's the config file:
I first ran
in the terminal, then
I should also mention that this is ran on the forked repository |
@crystina-z Retrained with latest changes and got MRR@10=0.351. However, I ran this experiment on the nimasadri11 fork. Should I add a pull request on that fork? (Currently waiting for the experiment results for the original repo) |
@d1shs0ap thanks for the update! yea for this issue let's wait for the result on the original repo for now? feel free to add another PR to nima's fork as well. thanks! |
@crystina-z The latest MRR I got after running on the original repo is
|
@d1shs0ap the score still looks a bit lowish to me tho. maybe let's PR the record to nima's branch and I'll check the score here. Could u please share your version of the |
@crystina-z Hey I made the PR to Nima's branch, below are my package versions:
and
Thanks! |
This is the task I replicated: https://github.com/capreolus-ir/capreolus/blob/feature/msmarco_psg/docs/reproduction/MS_MARCO.md, by following
docs/reproduction/sample_slurm_script.sh
.Findings
"Mini" version
MRR@10=0.283
was achieved, slightly below the 0.295 given in the docs (finished in 21h)"Full" version
MRR@10=0.346
was achieved as opposed to the expectedMRR@10=0.35+
, with the following configs(entire node): (finished in 42h)The text was updated successfully, but these errors were encountered: