Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_smac function does not work correctly on virtual interfaces #2

Closed
cappe987 opened this issue Oct 1, 2023 · 5 comments
Closed

Comments

@cappe987
Copy link
Owner

cappe987 commented Oct 1, 2023

In the file https://github.com/cappe987/wiretime/blob/main/src/liblink.c.

There is a temporary workaround that just sets the MAC to AA:AA:AA:AA:AA:AA, but ideally it should get the correct MAC address of the interface being transmitted on.

@Saavrm26
Copy link

Saavrm26 commented Oct 5, 2023

May I work on this issue

@cappe987
Copy link
Owner Author

cappe987 commented Oct 5, 2023

May I work on this issue

Go ahead :)

@Saavrm26
Copy link

Saavrm26 commented Oct 5, 2023

could you provide some resource for creating vlans(linux)
I have the project setup, but i am unable to setup a vlan for testing

@cappe987
Copy link
Owner Author

cappe987 commented Oct 5, 2023

Hi @Saavrm26
In trying to write some instructions for you I noticed that this was not an issue anymore. It must've been fixed when I did some refactoring. I'm not really sure myself how it would have occurred in the first place.

If you are still interested in contributing to some of the other issues you are free to do so. There is some explanation for setup in this issue #3. When I said "virtual interface" I was talking about veth interfaces, not VLANs. Veth is basically a virtual port, and are created in pairs that connect (like a cable).

@Saavrm26
Copy link

Saavrm26 commented Oct 6, 2023

Oh Thanks, I'll checkout issue #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants