Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc TODO #10

Open
1 of 13 tasks
nbokulich opened this issue Apr 10, 2020 · 0 comments
Open
1 of 13 tasks

Misc TODO #10

nbokulich opened this issue Apr 10, 2020 · 0 comments

Comments

@nbokulich
Copy link
Contributor

nbokulich commented Apr 10, 2020

Running list of miscellaneous to-do items (current list is from review of #7, edit or add new comment for additional items)

  • make dict of default params for each method

  • remove commented-out code blocks

  • add single-end mode for map reads etc

  • dereplicate redundant code between map_reads and filter

  • add unit tests for all _assemble.py methods (see expanded unit tests for assemble.py actions #12)

  • revisit feature table construction method in consensus_sequence

  • add validation for PileUpTSVFormat, GenBankFormat

  • move Bowtie2IndexDirFmt -> DNAFASTAFormat transformer to q2-types

  • add support for GenBank format (see note in plugin_setup.py)

  • ceil_coefficient description could be clearer; maybe specify that this is the max number of non-ACGT characters as a fraction of read length.

  • ceil_coefficient should have a range specified

  • refactor test_assemble.py code to reduce duplication where possible (e.g., the consensus sequence tests)

  • determine if it makes sense to allow overlapping sample ids in the consensus sequence step (i.e., one sample giving rise to multiple different genomes) - currently this is explicitly disallowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant