Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous name for 'add_base_attribute' method. #117

Open
kritchie opened this issue Jun 7, 2018 · 0 comments
Open

Ambiguous name for 'add_base_attribute' method. #117

kritchie opened this issue Jun 7, 2018 · 0 comments

Comments

@kritchie
Copy link
Contributor

kritchie commented Jun 7, 2018

The method 'add_base_attribute' is a little bit ambiguous. It doesn't 'add' attributes but replaces the self.attributes with the content passed to the method.

I suggest two options :

  1. Change the name of the method
  2. Change the method to 'add' to the self.attributes instead of replacing the dict completely.

I prefer option [1] but it should be more explicit. This would let the user of the class to have more freedom on what they want to set as parameters.

I can propose a PR for that if it's accepted and no one else is free to work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant