You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The method 'add_base_attribute' is a little bit ambiguous. It doesn't 'add' attributes but replaces the self.attributes with the content passed to the method.
I suggest two options :
Change the name of the method
Change the method to 'add' to the self.attributes instead of replacing the dict completely.
I prefer option [1] but it should be more explicit. This would let the user of the class to have more freedom on what they want to set as parameters.
I can propose a PR for that if it's accepted and no one else is free to work on that.
The text was updated successfully, but these errors were encountered:
The method 'add_base_attribute' is a little bit ambiguous. It doesn't 'add' attributes but replaces the self.attributes with the content passed to the method.
I suggest two options :
I prefer option [1] but it should be more explicit. This would let the user of the class to have more freedom on what they want to set as parameters.
I can propose a PR for that if it's accepted and no one else is free to work on that.
The text was updated successfully, but these errors were encountered: