Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataframePlot - don't require dataframe_name #469

Open
ryanSoley opened this issue Jul 25, 2024 · 1 comment · May be fixed by #472
Open

DataframePlot - don't require dataframe_name #469

ryanSoley opened this issue Jul 25, 2024 · 1 comment · May be fixed by #472
Labels
development Issues that require technical work. Associated PRs are required. enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs.

Comments

@ryanSoley
Copy link
Member

Is your enhancement request related to a problem? Please describe

it should be possible to instantiate visualizations without any arguments other than their experiments

Describe the solution you'd like

dataframe_name should default to None

https://github.com/capitalone/rubicon-ml/blob/main/rubicon_ml/viz/dataframe_plot.py#L46

if no dataframe_name is passed in, assume the dataframe requested is the first dataframe in the first experiment, e.g. self.dataframe_name = self.experiments[0].dataframes()[0].name. if experiments[0] has no dataframes, raise an error

@ryanSoley ryanSoley added enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs. development Issues that require technical work. Associated PRs are required. needs triage Issues that need to be prioritized by the core maintainers and added to a project board. and removed needs triage Issues that need to be prioritized by the core maintainers and added to a project board. labels Jul 25, 2024
@ryanSoley
Copy link
Member Author

depends on #468

@jeh362 jeh362 linked a pull request Jul 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Issues that require technical work. Associated PRs are required. enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant