Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to save models in ONNX format #458

Open
stephenpardy opened this issue Jun 28, 2024 · 2 comments
Open

Allow users to save models in ONNX format #458

stephenpardy opened this issue Jun 28, 2024 · 2 comments
Assignees
Labels
development Issues that require technical work. Associated PRs are required. enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs. feature Issues & PRs that capture new feature development. Issues require associated PRs.

Comments

@stephenpardy
Copy link
Contributor

Is your feature request related to a problem? Please describe
Currently Rubicon defaults to saving models in pickle. Pickles are known to be harmful in a number of cases. They are also not cross platform.

Describe the solution you'd like
Allow users to save models using ONNX.

Describe alternatives you've considered
Handle custom formats like XGBoost's json format - this is handy, but would require custom handling for each model format.

Additional context
https://onnx.ai/sklearn-onnx/auto_tutorial/plot_gexternal_xgboost.html

@stephenpardy stephenpardy added development Issues that require technical work. Associated PRs are required. feature Issues & PRs that capture new feature development. Issues require associated PRs. needs triage Issues that need to be prioritized by the core maintainers and added to a project board. labels Jun 28, 2024
@ryanSoley
Copy link
Member

we should be able to do this at the client level similarly to the H2O artifact enhancements in #415

@stephenpardy stephenpardy self-assigned this Jun 28, 2024
@stephenpardy stephenpardy added enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs. and removed needs triage Issues that need to be prioritized by the core maintainers and added to a project board. labels Jun 28, 2024
@stephenpardy
Copy link
Contributor Author

Some other comments:

  • For ONNX, we would likely require users to pass in a function that does the conversion. See e.g. https://github.com/onnx/onnxmltools. Unless we write/find a utility that automatically grabs the correct converter for a given model type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Issues that require technical work. Associated PRs are required. enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs. feature Issues & PRs that capture new feature development. Issues require associated PRs.
Projects
None yet
Development

No branches or pull requests

2 participants