Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug for setting allow_aggregation attribute through the remotely deployed api service web form #19

Open
ksneab7 opened this issue Mar 15, 2023 · 0 comments
Assignees

Comments

@ksneab7
Copy link
Contributor

ksneab7 commented Mar 15, 2023

General Information:

  • OS: Mac
  • Python version: 3.8.13
  • Library version: fma-connectors 0.0.1
    Describe the bug:
    When creating a federated model through the API service, we set the allow_aggregation attribute. This attribute is not properly set in the database using the connectors setter function for allow_aggregation. The fix lives in the serializers.py file on line 69.

To Reproduce:
Standup API service and try to set the allow aggregation attribute on the web form.

Expected behavior:
No matter what the attribute is set to the allow aggregation attribute will be set to "false". Even if an update patch is done from the web page the change will not propagate to the database entry

Additional context:
Proposed fix:
change logic on lines 69-74 in serializers.py to account for the instance.scheduler not existing when deploying remotely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants