Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live-update)!: implement return type ReadyResult #242

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

robingenz
Copy link
Member

@robingenz robingenz commented Aug 1, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #241

@robingenz robingenz self-assigned this Aug 1, 2024
@robingenz
Copy link
Member Author

robingenz commented Aug 3, 2024

This feature is now available as dev version until version 7.0.0 is released (as it contains breaking changes):

npm i @capawesome/[email protected]

The new ReadyResult interface:

/**
 * @since 7.0.0
 */
export interface ReadyResult {
  /**
   * The identifier of the previous bundle used.
   *
   * If `null`, the default bundle was used.
   *
   * @since 7.0.0
   */
  previousBundleId: string | null;
  /**
   * The identifier of the current bundle used.
   *
   * If `null`, the default bundle is being used.
   *
   * @since 7.0.0
   */
  currentBundleId: string | null;
  /**
   * Whether or not the app was reset to the default bundle.
   *
   * @since 7.0.0
   */
  rollback: boolean;
}

@robingenz robingenz marked this pull request as ready for review August 3, 2024 09:19
@robingenz robingenz added this to the v7.0.0 milestone Aug 3, 2024
@robingenz robingenz changed the title feat(live-update): implement return type ReadyResult feat(live-update)!: implement return type ReadyResult Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(live-update)!: notify if last update was successful
1 participant