Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump craft-archives #5124

Merged
merged 2 commits into from
Oct 21, 2024
Merged

build(deps): bump craft-archives #5124

merged 2 commits into from
Oct 21, 2024

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Oct 16, 2024

This update fixes LP#2083013, where some package-repositories declarations could conflict with default sources present in Noble.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@tigarmo tigarmo force-pushed the work/CRAFT-3538-noble-key-conflict branch from 56a1ed5 to c13c393 Compare October 16, 2024 20:54
@tigarmo tigarmo changed the base branch from main to hotfix/8.4 October 16, 2024 20:54
@tigarmo tigarmo closed this Oct 16, 2024
@tigarmo tigarmo reopened this Oct 16, 2024
@tigarmo tigarmo force-pushed the work/CRAFT-3538-noble-key-conflict branch 2 times, most recently from afebe09 to c136094 Compare October 17, 2024 13:55
@tigarmo
build(deps): bump craft-archives
1c11c58 
This update fixes LP#2083013, where some package-repositories declarations
could conflict with default sources present in Noble and later.
@tigarmo tigarmo force-pushed the work/CRAFT-3538-noble-key-conflict branch from c136094 to 1c11c58 Compare October 17, 2024 15:52
@tigarmo tigarmo closed this Oct 17, 2024
@tigarmo tigarmo reopened this Oct 17, 2024
@tigarmo tigarmo requested review from mr-cal and lengau October 18, 2024 13:55
lengau
lengau approved these changes Oct 18, 2024
View reviewed changes
requirements-devel.txt Outdated Show resolved Hide resolved
requirements-docs.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
tests/spread/core24/package-repositories/task.yaml Show resolved Hide resolved
tests/spread/core24/package-repositories/test-key-conflict/snapcraft.yaml Show resolved Hide resolved
tests/spread/core24/package-repositories/test-key-conflict/snapcraft.yaml Show resolved Hide resolved
mr-cal
mr-cal approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the assumption that @tigarmo will update the requirement files after releasing craft-archives.

@tigarmo tigarmo added the squash label Oct 21, 2024
@tigarmo tigarmo marked this pull request as ready for review October 21, 2024 15:29
@tigarmo tigarmo merged commit 47c3c21 into hotfix/8.4 Oct 21, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigarmo @lengau @mr-cal