Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also return info about NVMe devices #140

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

ogayot
Copy link
Member

@ogayot ogayot commented Dec 12, 2023

Block probing now includes a new key called "nvme" which contains a Udev dump of the SUBSYSTEM="nvme" devices. Each entry corresponds to a NVMe controller and has all the properties we need to find out if drives using this NVMe controller are "local", "over TCP" or soemthing else.

@ogayot ogayot marked this pull request as draft December 12, 2023 14:46
@ogayot
Copy link
Member Author

ogayot commented Dec 12, 2023

Marking as a draft since this might need to be implemented in curtin's storage_config instead.

@ogayot ogayot changed the title Also return info about NVMe devices using nvme list Also return info about NVMe devices Dec 13, 2023
@ogayot ogayot marked this pull request as ready for review December 13, 2023 17:04
Copy link
Collaborator

@Chris-Peterson444 Chris-Peterson444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogayot ogayot merged commit f34ae3c into canonical:master Jan 10, 2024
4 checks passed
@ogayot ogayot deleted the nvme-o-tcp branch January 10, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants