Windows Support Improvements #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alanbach
commented
Nov 15, 2024
alanbach
commented
- Added Support for Windows Server 2025 ISO and VHDX builds
- Added Support for Windows 11 ISO builds
- Autounattend.xml Template file clean-ups
- Added a new timeout parameter
Added Support for Windows 11 ISO builds Autounattend.xml Template file clean-ups Added a new timeout parameter
alexsander-souza
approved these changes
Nov 18, 2024
| swtpm socket --daemon --tpm2 --tpmstate dir=/tmp/swtpm --ctrl type=unixio,path=/tmp/swtpm/swtpm-sock --log level=10 | ||
| endif | ||
| ifneq ($(strip $(VHDX)),) | ||
| qemu-img convert -p -O raw ${VHDX} windows_builder.img; \ |
There was a problem hiding this comment.
this could be a separate shell script, it would be clearer to understand
There was a problem hiding this comment.
Noted, will add to TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.