-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing support for wildcard domain names #312
Comments
troyanov
added a commit
to troyanov/microcluster
that referenced
this issue
Jan 12, 2025
Use VerifyHostname [0] instead of a string comparison, as it allows usage of wildcard certificate (*.maas.internal) for every cluster member. Release unique constraint on certificate, as in case of wildcard certificate it can be the same for all the cluster members. [0]: https://pkg.go.dev/crypto/x509#Certificate.VerifyHostname Resolves canonical#312
troyanov
added a commit
to troyanov/microcluster
that referenced
this issue
Jan 12, 2025
Use VerifyHostname [0] instead of a string comparison, as it allows usage of wildcard certificate for every cluster member. Release unique constraint on certificate, as in case of wildcard certificate it can be the same for all the cluster members. [0]: https://pkg.go.dev/crypto/x509#Certificate.VerifyHostname Resolves canonical#312
troyanov
added a commit
to troyanov/microcluster
that referenced
this issue
Jan 12, 2025
Use VerifyHostname [0] instead of a string comparison, as it allows usage of wildcard certificate for every cluster member. Release unique constraint on certificate, as in case of wildcard certificate it can be the same for all the cluster members. [0]: https://pkg.go.dev/crypto/x509#Certificate.VerifyHostname Resolves canonical#312 Signed-off-by: Anton Troyanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MicroCluster requires the name of the cluster member to be a FQDN and it also checks that this name is among certificate SAN.
microcluster/internal/rest/resources/control.go
Line 83 in d50fa50
However usage of
ValueInSlice
doesn't work for certificates that have wildcard DNSThis certificate won't work for
member1.maas.internal
The text was updated successfully, but these errors were encountered: