Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroCloud should validate API/Schema versions before clustering #166

Open
masnax opened this issue Sep 26, 2023 · 2 comments
Open

MicroCloud should validate API/Schema versions before clustering #166

masnax opened this issue Sep 26, 2023 · 2 comments
Labels
Feature New feature, not a bug

Comments

@masnax
Copy link
Contributor

masnax commented Sep 26, 2023

Attempting to set up MicroCloud with services (LXD, MicroCeph, MicroOVN) that have mismatched API/Schema versions, the setup will happily move along and then fail during those services' own version validation when forming the cluster with the error or one like it:

Error: Peer "n2" failed to join the cluster: Failed to update cluster status of services: Failed to join "LXD" cluster: Failed to configure cluster: Failed request to add member: The joining server version doesn't match (expected 5.18 with API count 360)

MicroCloud should instead incorporate the API versions of each service into the mdns response so that the system doing the lookup (calling microcloud init) can properly ignore them with a syslog message reporting that the node was skipped due to a version mismatch.

@roosterfish roosterfish added the Feature New feature, not a bug label Nov 22, 2023
@roosterfish
Copy link
Contributor

@masnax I understand this is now fixed due to version enforcement?

@masnax
Copy link
Contributor Author

masnax commented Nov 15, 2024

Hmm, maybe not necessarily. If a cherry pick with an API extension is moved into the LTS without a patch version increase (like when using 5.21/edge vs 5.21/stable), we might still fail like this.

We should fetch the set of API extensions and schema updates and make sure they are the same across all members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, not a bug
Projects
None yet
Development

No branches or pull requests

2 participants