From 11d4bfc88c97d2cac3b624100330bec32933739d Mon Sep 17 00:00:00 2001
From: montag451 <montag451@laposte.net>
Date: Tue, 3 Dec 2024 23:04:26 +0100
Subject: [PATCH 1/2] lxc/completion: Add `cmpImageFingerprintsFromRemote` and
 completions for `image alias create`

Signed-off-by: montag451 <montag451@laposte.net>
(cherry picked from commit 41929ea4d6c78460cd1f555e8f0e814c79f32bf4)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
License: Apache-2.0
---
 lxc/completion.go  | 23 +++++++++++++++++++++++
 lxc/image_alias.go | 17 +++++++++++++++++
 2 files changed, 40 insertions(+)

diff --git a/lxc/completion.go b/lxc/completion.go
index bcbc00b729d8..328d5cb6bee9 100644
--- a/lxc/completion.go
+++ b/lxc/completion.go
@@ -223,6 +223,29 @@ func (g *cmdGlobal) cmpImages(toComplete string) ([]string, cobra.ShellCompDirec
 	return results, cmpDirectives
 }
 
+// cmpImageFingerprintsFromRemote provides shell completion for image fingerprints.
+// It takes a partial input string and a remote and returns image fingerprints for that remote along with a shell completion directive.
+func (g *cmdGlobal) cmpImageFingerprintsFromRemote(toComplete string, remote string) ([]string, cobra.ShellCompDirective) {
+	if remote == "" {
+		remote = g.conf.DefaultRemote
+	}
+
+	remoteServer, _ := g.conf.GetImageServer(remote)
+
+	images, _ := remoteServer.GetImages()
+
+	results := make([]string, 0, len(images))
+	for _, image := range images {
+		if !strings.HasPrefix(image.Fingerprint, toComplete) {
+			continue
+		}
+
+		results = append(results, image.Fingerprint)
+	}
+
+	return results, cobra.ShellCompDirectiveNoFileComp
+}
+
 // cmpInstanceKeys provides shell completion for all instance configuration keys.
 // It takes an instance name to determine instance type and returns a list of all instance configuration keys along with a shell completion directive.
 func (g *cmdGlobal) cmpInstanceKeys(instanceName string) ([]string, cobra.ShellCompDirective) {
diff --git a/lxc/image_alias.go b/lxc/image_alias.go
index 42af3c7abc1c..b0b0deeee57c 100644
--- a/lxc/image_alias.go
+++ b/lxc/image_alias.go
@@ -62,6 +62,23 @@ func (c *cmdImageAliasCreate) command() *cobra.Command {
 
 	cmd.RunE = c.run
 
+	cmd.ValidArgsFunction = func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		if len(args) > 1 {
+			return nil, cobra.ShellCompDirectiveNoFileComp
+		}
+
+		if len(args) == 0 {
+			return c.global.cmpRemotes(toComplete, true)
+		}
+
+		remote, _, found := strings.Cut(args[0], ":")
+		if !found {
+			remote = ""
+		}
+
+		return c.global.cmpImageFingerprintsFromRemote(toComplete, remote)
+	}
+
 	return cmd
 }
 

From 4a519f3d01faadc1666bf8609fa9a21b384330bd Mon Sep 17 00:00:00 2001
From: Kadin Sayani <kadin.sayani@canonical.com>
Date: Tue, 7 Jan 2025 15:53:25 -0700
Subject: [PATCH 2/2] lxc/completion: Add completions for `lxc image alias
 list|delete|rename`

Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
---
 lxc/image_alias.go | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/lxc/image_alias.go b/lxc/image_alias.go
index b0b0deeee57c..1a0d2a4a3a26 100644
--- a/lxc/image_alias.go
+++ b/lxc/image_alias.go
@@ -126,6 +126,14 @@ func (c *cmdImageAliasDelete) command() *cobra.Command {
 
 	cmd.RunE = c.run
 
+	cmd.ValidArgsFunction = func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		if len(args) > 0 {
+			return nil, cobra.ShellCompDirectiveNoFileComp
+		}
+
+		return c.global.cmpImages(toComplete)
+	}
+
 	return cmd
 }
 
@@ -175,6 +183,14 @@ Filters may be part of the image hash or part of the image alias name.
 
 	cmd.RunE = c.run
 
+	cmd.ValidArgsFunction = func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		if len(args) > 0 {
+			return nil, cobra.ShellCompDirectiveNoFileComp
+		}
+
+		return c.global.cmpRemotes(toComplete, true)
+	}
+
 	return cmd
 }
 
@@ -274,6 +290,14 @@ func (c *cmdImageAliasRename) command() *cobra.Command {
 
 	cmd.RunE = c.run
 
+	cmd.ValidArgsFunction = func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		if len(args) > 0 {
+			return nil, cobra.ShellCompDirectiveNoFileComp
+		}
+
+		return c.global.cmpImages(toComplete)
+	}
+
 	return cmd
 }