From 5432e5a3ba02c5c0f495a9d51677b0d40ffafeb1 Mon Sep 17 00:00:00 2001
From: Gabriel Mougard <gabriel.mougard@canonical.com>
Date: Mon, 2 Sep 2024 18:11:38 +0200
Subject: [PATCH] lxd/device/gpu_physical: forbid CDI GPU hotplugging

CDI GPU are not hotpluggable because the configuration of a CDI GPU requires a LXC hook that
is only run at instance start. A classic GPU device can be hotplugged.

Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
---
 lxd/device/gpu_physical.go | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/lxd/device/gpu_physical.go b/lxd/device/gpu_physical.go
index 3348a5700cbd..8e3e2f8e4010 100644
--- a/lxd/device/gpu_physical.go
+++ b/lxd/device/gpu_physical.go
@@ -21,6 +21,7 @@ import (
 	"github.com/canonical/lxd/lxd/storage/filesystem"
 	"github.com/canonical/lxd/lxd/util"
 	"github.com/canonical/lxd/shared"
+	"github.com/canonical/lxd/shared/logger"
 )
 
 const gpuDRIDevPath = "/dev/dri"
@@ -598,6 +599,31 @@ func (d *gpuPhysical) stopCDIDevices(configDevices cdi.ConfigDevices, runConf *d
 	return nil
 }
 
+// CanHotPlug returns whether the device can be managed whilst the instance is running.
+// CDI GPU are not hotpluggable because the configuration of a CDI GPU requires a LXC hook that
+// is only run at instance start. A classic GPU device can be hotplugged.
+func (d *gpuPhysical) CanHotPlug() bool {
+	if d.inst.Type() == instancetype.Container {
+		if d.config["id"] != "" {
+			// Check if the id of the device match a CDI format.
+			cdiID, err := cdi.ToCDI(d.config["id"])
+			if err != nil {
+				d.logger.Error("Failed to parse CDI ID when hotplugging", logger.Ctx{"err": err})
+				return false
+			}
+
+			if !cdiID.Empty() {
+				d.logger.Warn("Hotplugging CDI devices is not supported", logger.Ctx{"id": d.config["id"]})
+				return false
+			}
+		}
+
+		return true
+	}
+
+	return false
+}
+
 // Stop is run when the device is removed from the instance.
 func (d *gpuPhysical) Stop() (*deviceConfig.RunConfig, error) {
 	runConf := deviceConfig.RunConfig{