Content interface for MicroOVN #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
masnax
commented
Sep 18, 2023
| export OVS_BINDIR="${SNAP}/bin/" | ||
| export OVS_SBINDIR="${SNAP}/bin/" | ||
|
|
||
| mkdir -p "${OVS_SYSCONFDIR}/openvswitch" |
There was a problem hiding this comment.
Not sure if there should be some cleanup here in case we set up openvswitch_builtinin daemon.start, then installed and uninstalled MicroOVN.
simondeziel
requested changes
Oct 20, 2023
|
|
||
| if ! test -e /etc/ovn ; then | ||
| mkdir /etc/ovn | ||
| fi |
There was a problem hiding this comment.
<code-golf>
[ -d /etc/ovn ] || mkdir /etc/ovn
</code-golf>
|
|
||
| ln -snf ${SNAP_DATA}/microovn/data/pki/client-cert.pem /etc/ovn/cert_host | ||
| ln -snf ${SNAP_DATA}/microovn/data/pki/client-privkey.pem /etc/ovn/key_host | ||
| ln -snf ${SNAP_DATA}/microovn/data/pki/cacert.pem /etc/ovn/ovn-central.crt |
There was a problem hiding this comment.
shellcheck wants those to be quoted.
| #!/bin/sh | ||
|
|
||
|
|
||
| ln -snf ${SNAP_DATA}/microovn/run/switch /run/openvswitch |
| if [ "${openvswitch_builtin:-"false"}" = "true" ]; then | ||
| export OVS_RUNDIR="${SNAP_COMMON}/openvswitch/run/" | ||
| ( | ||
| set -e |
There was a problem hiding this comment.
I'm probably missing something but I couldn't find an explanation for having OVS_RUNDIR set outside that subshell? In fact, I don't understand the purpose of those 2 subshells. If you could shed some light I'd appreciate, thanks.
|
@masnax are you still working on this? If not please could you close until you get back to it. Ta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the hypothetical
MicroOVNovn-confslot, which does not yet exist. This will be a draft until it does.