-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include humanize_list function as a utility #183
Comments
Are we sure that this lib is the right place for this function? I can see that in the majority of cases the list if being humanized to be emitted/logged, but a side-effect of this is that the libs (like craft-parts and -providers) would start having craft-cli as a dependency. Which isn't awful necessarily , but is a consequence we need to consider. ... At the same time, I'm not a huge fan of a grab-bag "craft-util" lib because it feels a bit chaotic, so I don't have any better suggestions, heh. |
Maybe we could get this landed and use |
@tigarmo I was just typing the same thing |
python-humanize/humanize#110 landed this month in 4.11.0 so it is finally ready for us to use! |
What needs to get done
craft-cli
: https://github.com/canonical/craft-parts/blob/main/craft_parts/utils/formatting_utils.pycraft-cli
releasecraft-parts
implementation that the function exists in the other location so we can copy bug fixes if needed. (No functional changes in craft-parts)Why it needs to get done
Reduced copy/pasting of code for improved maintainability
The text was updated successfully, but these errors were encountered: