Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss whether we should maintain 'line-length = 99' #149

Open
tigarmo opened this issue Jun 13, 2023 · 2 comments
Open

Discuss whether we should maintain 'line-length = 99' #149

tigarmo opened this issue Jun 13, 2023 · 2 comments

Comments

@tigarmo
Copy link
Collaborator

tigarmo commented Jun 13, 2023

This goes against Starbase's default, but the reformatting is possibly quite noisy (git-black-wise). We could go either way, so we should discuss and make a decision.

@lengau
Copy link
Contributor

lengau commented Jun 13, 2023

cc @syu-w

It's probably worth discussing the starbase value too. It's currently at 88 because that's the default in tools like black and because it inherited those numbers from charmcraft (which seems to have used those numbers because they were the default).

@syu-w
Copy link
Contributor

syu-w commented Jun 13, 2023

I did a quick scan and charmcraft had around 800 lines code exceed 88 line length.
find . -iname "*.py" -exec cat {} \; | awk '{print length}' | sort -g | uniq -c

I am ok with 88, 99, or 100. Maybe we should see if our display can easily show them in one screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants