Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UATs not working on host's python3.10 #79

Open
misohu opened this issue Jul 4, 2024 · 5 comments
Open

UATs not working on host's python3.10 #79

misohu opened this issue Jul 4, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@misohu
Copy link
Member

misohu commented Jul 4, 2024

Bug Description

UAT's will not work on tox installed on host's python3.10 (they only work on python3.8).

The bug was reported in this issue.

To Reproduce

  1. Run any Charmed Kubeflow deployment with juju (observer on juju 3.4 and CKF 1.8/stable)
  2. Run the UATs (observed with tox -e kubeflow-remote)

Environment

Observed on juju 3.4.4, aks v1.28.9, kubeflow 1.8/stable

Relevant Log Output

Log from here canonical/bundle-kubeflow#951

Additional Context

No response

@misohu misohu added the bug Something isn't working label Jul 4, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5958.

This message was autogenerated

@kimwnasptd
Copy link
Contributor

@misohu @NohaIhab @DnPlas @orfeas-k what are the complications and cons of updating this, for the dev experience?

Can we convert the code to work for both Python 3.8 and 3.10?

@misohu
Copy link
Member Author

misohu commented Jul 17, 2024

Hey @kimwnasptd

If we wan to run on 3.10 we just need to migrate the requirements to 3.10 and maybe fix some issues. Right now the runners have 3.10 so we can completely drop the 3.8 support instead of supporting 2 pythons. WDYT?

@mvlassis
Copy link
Contributor

We are planning on migrating to Python 3.10 for the tests. After that, support for Python 3.8 will be dropped.

@motjuste
Copy link

I have successfully run the tests with Python 3.10 after overriding the websockets requirement (transitively, via python-libjuju). To support both Python 3.8 and Python 3.9+, you'd then have to override websockets too based on Python version (as done by libjuju at that link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants