Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin notebook dependencies #24

Closed
phoevos opened this issue Sep 11, 2023 · 0 comments · Fixed by #25
Closed

Pin notebook dependencies #24

phoevos opened this issue Sep 11, 2023 · 0 comments · Fixed by #25
Labels
enhancement New feature or request

Comments

@phoevos
Copy link
Contributor

phoevos commented Sep 11, 2023

Currently, the notebooks only pin dependencies for which specific versions were required for the tests to work at the time of development. Although we should always ensure that the tests work for the latest versions of the installed packages, we should strive to make them more reproducible, introducing the requirement pinning practices implemented in our other repositories.

This is also loosely related to the effort around running each notebook in an isolated environment since we don't want dependencies installed as part of one test, interfering with subsequent ones:

Goal

  • Refactor direct Python dependencies into requirements.in files
  • Provide an action for compiling those into requirements.txt files
  • Install the corresponding dependencies from requirements.txt before running each notebook
@phoevos phoevos added the enhancement New feature or request label Sep 11, 2023
@phoevos phoevos mentioned this issue Sep 12, 2023
Merged
phoevos added a commit that referenced this issue Sep 19, 2023
@phoevos
feat: Pin Python dependencies (#25)
c376579 
* Move notebook dependencies to `requirements.in` files
* Compile dependencies into `requirements.txt` files using the root-level tox `update-requirements` action
* Install dependencies from the corresponding `requirements.txt` before running each notebook

Closes #24

Signed-off-by: Phoevos Kalemkeris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Pin Python dependencies canonical/charmed-kubeflow-uats
1 participant
@phoevos