New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How should we document getters? #6

Open

phillipskevin opened this issue Jun 5, 2019 · 1 comment

Contributor

phillipskevin commented Jun 5, 2019

These all work:

class Obj extends DefineObject {
    static define = {
        name: { default: "Kevin" },
        get excitedName() {
            return this.name + "!!!";
        },
        lowerCaseName: {
            get() {
                return this.name.toLowerCase()
            }
        }
    };
    get upperCaseName() {
        return this.name.toUpperCase()
    }
  }

Should we document them all?

Contributor

matthewp commented Jun 6, 2019

Second signature in the get docs I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment