Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial template invocations should support content #297

Open
RyanMilligan opened this issue Sep 4, 2018 · 1 comment
Open

Partial template invocations should support content #297

RyanMilligan opened this issue Sep 4, 2018 · 1 comment

Comments

@RyanMilligan
Copy link

When invoking a custom tag, it is possible to place content inside it which will then be rendered as part of the custom tag. Partial template invocations use the same basic mechanism as custom tags (renderer functions), so I would expect them to support it as well.

For example:

{{<test}}This is a partial! <b><content /></b>{{/test}}

{{>test}}And here is the content.{{/test}}

Currently, this throws a lot of internal null-ref exceptions, which suggests that the idea of providing content to a partial invocation simply hasn't been considered.

@justinbmeyer
Copy link
Contributor

I think the issue here is that helpers (and tags) might not get passed down through these partials.

It would be cool if scope.templates or scope.content could access the underlying template or content and then just pass it to the partial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants