Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some complex tag values will still break output BAM header, even after hotfix 2.3.4 #33

Open
byb121 opened this issue Aug 27, 2019 · 2 comments
Assignees
Labels

Comments

@byb121
Copy link
Contributor

byb121 commented Aug 27, 2019

for example:
in the input BAM:

@RG	ID:2977244	PL:HiSeq	PU:13$'"617_6	LB:EM-2_rnas"|||eq 1!100$5739_52200	PI:125	MI:494	DS:s h`o r\\\	PG:2977244	SM:EM-2	CN:SANGER

star_mapping.pl will escape the tags correctly and pass them to star, so the command line is like this:

 #!/bin/bash
set -eux
 /opt/wtsi-cgp/bin/STAR  [...other_star_options] --outSAMattrRGline "ID:2977244" "PL:HiSeq" "PU:13\$'\"617_6" "LB:EM-2_rnas\"|||eq 1\!100\$5739_52200" "PI:125" "MI:494" "DS:s h\`o r\\\\\\" "PG:2977244" "SM:test_bad_header" "CN:SANGER"

However, the output BAM has header:

@RG	ID:2977244	PL:HiSeq	PU:13$'"617_6	LB:EM-2_rnas	|||eq	1\!100$5739_52200"	PI:125	MI:494	DS:s h`o r\\\	PG:2977244	SM:test_bad_header	CN:SANGER

Note that the LB tag has been split into three tags.

It looks like a bug in Star.

@byb121
Copy link
Contributor Author

byb121 commented Aug 27, 2019

I'll test if the latest version of Star outputs the same header.

@byb121 byb121 changed the title some complex tag value will still break output BAM header, even after hotfix 2.3.4 some complex tag values will still break output BAM header, even after hotfix 2.3.4 Aug 27, 2019
@byb121 byb121 self-assigned this Aug 27, 2019
@byb121
Copy link
Contributor Author

byb121 commented Aug 28, 2019

latest version of STAR:2.7.2a failed to interpret the RG line correctly as well, as in the issue I raised here: alexdobin/STAR#725

We'll have to wait for fixes in STAR.

@byb121 byb121 added the wontfix label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant