Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set seqkit sequencing type in configuration file #4

Open
vaofford opened this issue Dec 2, 2022 · 1 comment
Open

set seqkit sequencing type in configuration file #4

vaofford opened this issue Dec 2, 2022 · 1 comment
Assignees
Labels
configuration Propose changes to configuration files

Comments

@vaofford
Copy link
Collaborator

vaofford commented Dec 2, 2022

When a fastq has a missing 1st entry (due to short reads and trimming) seqkit seq infers that the type of sequences in the file is "unlimit" rather than "dna": https://bioinf.shenwei.me/seqkit/usage/#seq

"unlimit" type sequences cannot be complemented and the files currently returned by --read_transform "reverse_complement" are just reversed. This will mean no reads match template libraries for quantification.

Specify -t dna or --seq-type dna will fix. This could limits quants from working with RNA sequences - is this a potential issue?

@vaofford vaofford added the configuration Propose changes to configuration files label Dec 2, 2022
@vaofford
Copy link
Collaborator Author

vaofford commented Dec 2, 2022

Several ways we could tackle this:

  1. code change to seq-kit module -> ideally avoid this so we keep the module generic and working for all sequencing types
  2. update the seqkit module default commands in the configuration file (https://github.com/cancerit/QUANTS/blob/develop/conf/modules.config) -> would require a new release
  3. add the seqkit_seq_options to the parameter JSON we supply at run time -> wouldn't require a new release

@jamieb63 does (3) work ok with a test set of data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Propose changes to configuration files
Projects
None yet
Development

No branches or pull requests

2 participants