[Backport release-8.4.0] Support using process instance migration from the zeebe client #1013

backport-action · 2024-01-03T09:12:30Z

Description

Backport of #1012 to release-8.4.0.

relates to #972

Simplifies the map and filter by placing map before filter (cherry picked from commit 6e20e51)

Currently, only the bindService method needs to be ignored as it is explicitly declared by GatewayImplBase. But the other methods from the interfaces BindableService and AsyncService are not retrieved by getDeclaredMethods. For this, we'll need to use getMethods. However, that method will also pass undeclared methods like equals which we'll need to explicitly ignore. This we can easily achieve using a list of strings. (cherry picked from commit b757270)

This test was not testing what was intended. It wants to ensure that all the RPCs of the gateway are supported by the GrpcToLogStreamGateway. It does this by verifying that the GrpcToLogStreamGateway declares an implementation for each of the gateway's methods. However, the getDeclaredMethods doesn't return those. Possibly these were moved to AsyncService at some point. Note that this is generated code and that this may have been changed by changes upstream in the grpc library. Instead, we must use getMethods to retrieve all methods available on this class (also those defined through default implementations on its interfaces). When we do that, we must also ignore a bunch of undeclared methods, like equals and hashCode. What we're left with is a failing test that fails for two missing methods: - streamActivatedJobs - migrateProcessInstance (cherry picked from commit 00b726b)

Fixes failing test case: - GrpcToLogStreamGatewayTest.testImplementsGatewayEndpoint#migrateProcessInstance (cherry picked from commit cb3a81a)

It's not yet possible to support this method as it functions differently from the other RPCS. Typically, the RPCs are implemented by appending a command to the log stream, but for streaming RPCs it works differently. Instead, the gateway opens a stream through which the broker can stream events. As I understand the implementation in Zeebe, this works without appending a command. In order to support this in ZPT, some new mechanism must be added that allows streaming events to the calling client. (cherry picked from commit 46c70fa)

Adds a simple example test case that shows we can migrate a process instance through the zeebe client in ZPT. (cherry picked from commit c6e082b)

(cherry picked from commit 0c24ced)

This test is quite important, because it ensure we don't forget supporting RPCs in ZPT. To help clarify this, I've added instructions in case the test fails. (cherry picked from commit 46a2e5c)

github-actions · 2024-01-03T09:20:41Z

Test Results

48 files + 1 48 suites +1 1m 41s ⏱️ +4s
127 tests +21 126 ✅ +20 0 💤 ±0 1 ❌ +1
403 runs +61 402 ✅ +60 0 💤 ±0 1 ❌ +1

For more details on these failures, see this check.

Results for commit d76f381. ± Comparison against base commit fe33845.

♻️ This comment has been updated with latest results.

korthout · 2024-01-03T10:02:40Z

Encountered known flaky test:

PullRequestProcessTest.testRemindReviewer is flaky #984

github-actions

bors merge

ghost · 2024-01-03T10:12:14Z

Build succeeded:

Test summary

korthout added 8 commits January 3, 2024 09:12

refactor: remove duplicate getName

f048bf6

Simplifies the map and filter by placing map before filter (cherry picked from commit 6e20e51)

fix: support migrate process instance rpc

1c9a9ef

Fixes failing test case: - GrpcToLogStreamGatewayTest.testImplementsGatewayEndpoint#migrateProcessInstance (cherry picked from commit cb3a81a)

test: support migrating process instances

267db0f

Adds a simple example test case that shows we can migrate a process instance through the zeebe client in ZPT. (cherry picked from commit c6e082b)

fix: support instance migration response

9d13cd5

(cherry picked from commit 0c24ced)

docs: describe what to do when test fails

d76f381

This test is quite important, because it ensure we don't forget supporting RPCs in ZPT. To help clarify this, I've added instructions in case the test fails. (cherry picked from commit 46a2e5c)

backport-action mentioned this pull request Jan 3, 2024

Support using process instance migration from the zeebe client #1012

Merged

7 tasks

github-actions bot approved these changes Jan 3, 2024

View reviewed changes

ghost merged commit 4894ff7 into release-8.4.0 Jan 3, 2024
10 of 11 checks passed

ghost deleted the backport-1012-to-release-8.4.0 branch January 3, 2024 10:12

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport release-8.4.0] Support using process instance migration from the zeebe client #1013

[Backport release-8.4.0] Support using process instance migration from the zeebe client #1013

backport-action commented Jan 3, 2024

github-actions bot commented Jan 3, 2024 •

edited

Loading

korthout commented Jan 3, 2024

github-actions bot left a comment

ghost commented Jan 3, 2024

[Backport release-8.4.0] Support using process instance migration from the zeebe client #1013

[Backport release-8.4.0] Support using process instance migration from the zeebe client #1013

Conversation

backport-action commented Jan 3, 2024

Description

github-actions bot commented Jan 3, 2024 • edited Loading

Test Results

korthout commented Jan 3, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

ghost commented Jan 3, 2024

github-actions bot commented Jan 3, 2024 •

edited

Loading