fix(document): Fix FEEL document serialization #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
reviewed
Dec 5, 2024
| @@ -68,6 +68,7 @@ public static PropertyBuilder retryBackoff() { | |||
| return StringProperty.builder() | |||
| .id("retryBackoff") | |||
| .label("Retry backoff") | |||
| .feel(FeelMode.disabled) | |||
There was a problem hiding this comment.
Should we generate ETs again in this PR so that all the changes are grouped together?
There was a problem hiding this comment.
@johnBgood I would do this in a separate PR.
johnBgood
reviewed
Dec 5, 2024
| import org.camunda.feel.syntaxtree.Val; | ||
| import org.camunda.feel.valuemapper.JavaCustomValueMapper; | ||
|
|
||
| public class CustomValueMapper extends JavaCustomValueMapper { |
There was a problem hiding this comment.
Can we have a simple test to highlight the issue and double-check that it's fixed (for the future mostly)?
There was a problem hiding this comment.
Sure, I can include it in my Box Connector PR as we need to get this going
johnBgood
approved these changes
Dec 5, 2024
sbuettner
force-pushed
the
fix-document-handling-feel
branch
from
7903640 to
3f16f44
Compare
sbuettner
added a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix FEEL expression handling for documents