Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(preview-env): Use a static name for the TLS secret #1734

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

clementnero
Copy link
Contributor

Description

Related to https://github.com/camunda/team-infrastructure/issues/510

This PR introduces the use of a static name for the secret containing the TLS certificate of the preview environment.

Reasons:

  • Using a dynamic name implies using a* in the ArgoCD ignoreDifferences configuration, which does not seem to be well supported as ArgoCD sometimes synchronizes the TLS secret (tls.crt, tls.key), whereas differences should be ignored
  • When this happens, the TLS certificate of the preview environment is (removed) no longer exposed. Instead, a self-signed certifcat is temporarily used.

@clementnero clementnero requested a review from a team as a code owner January 17, 2024 10:38
@github-actions github-actions bot temporarily deployed to connectors-preview-env-fix-c8sm January 17, 2024 10:48 Destroyed
@clementnero clementnero added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 60da11e Jan 17, 2024
7 checks passed
@clementnero clementnero deleted the preview-env-fix-ignore-diff branch January 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants