chore(template) add inbound/outbound params to documentationRef where it possible #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuettner
reviewed
Jan 16, 2024
| @@ -4,7 +4,7 @@ | |||
| "id": "io.camunda.connectors.inbound.AWSSNS.Boundary.v1", | |||
| "description": "Receive events from AWS SNS", | |||
| "version": 2, | |||
| "documentationRef": "https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/aws-sns-inbound/", | |||
| "documentationRef": "https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sns/?amazonsns=inbound/", | |||
There was a problem hiding this comment.
@Oleksiivanov You might need to remove the pending slash. For me it leads to opening the page with the outbound tab selected: https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sns/?amazonsns=inbound/
There was a problem hiding this comment.
Thank you, move for now to draft , and recheck all links
sbuettner
reviewed
Jan 16, 2024
connectors/aws/aws-sns/element-templates/aws-sns-inbound-boundary.json
Outdated
Show resolved
Hide resolved
Oleksiivanov
force-pushed
the
add-params-to-doc-ref-in-templates
branch
from
972a773 to
266c1f0
Compare
sbuettner
previously approved these changes
Jan 16, 2024
Oleksiivanov
force-pushed
the
add-params-to-doc-ref-in-templates
branch
from
266c1f0 to
4b2adc3
Compare
@sbuettner, could you please reapprove this PR? I updated the branch and your approve was dismissed |
sbuettner
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add inbound/outbound parameters to documentationRef in the templates where it possible
closes #
https://github.com/camunda/developer-experience/issues/215
next step : do the same in the modeler