Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): OpenAPI generator issues with Petstore example #1679

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

chillleader
Copy link
Member

Description

  1. Added a "target" prefix to all property IDs so they look like operationId_body_propertyName or operationId_headers_propertyName. Sometimes properties in body (derived from the JSON schema) can have the same name as parameters.
  2. Fixed an issue with scan command where unsupported operations were never displayed
  3. Changed the generate command output so it returns a single JSON object when only one template was generated, instead of an array of element template JSON objects.
  4. Adjusted the README: removed the invalid example, added a note about unsupported operations.

Related issues

See https://camunda.slack.com/archives/C0350959WG1/p1705053321728369

@chillleader chillleader requested a review from a team as a code owner January 12, 2024 18:42
@chillleader chillleader self-assigned this Jan 12, 2024
@chillleader chillleader requested a review from sbuettner January 15, 2024 08:57
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements.

@chillleader chillleader added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit c98bd48 Jan 16, 2024
3 checks passed
@chillleader chillleader deleted the openapi-fix-petstore-example branch January 16, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants