-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workflows) fix prev_tag script #1636
Conversation
02aca3e
to
89e676c
Compare
Hi @Oleksiivanov ! Thanks for putting this together - I especially appreciate the tests you included [edit: and your thorough description of the tag definitions]. In the PR description, may you please explain:
That extra context would help me review the code better and would help future readers who might need to refer to this in future. Thanks :) |
883121e
to
01eaa6f
Compare
01eaa6f
to
f20f123
Compare
added Overview and test results to description |
Thanks for your changes @Oleksiivanov, they look great! |
Overview
This PR introduces significant enhancements to the existing script used for determining previous version tags in a Git repository. The script efficiently handles various tag formats, including normal versions, release candidates (RC), and alpha versions. It is utilized in our release workflow, as detailed in RELEASE.yaml.
The script's primary purpose is to identify the previous tag for generating a changelog after each release. The previous version of this script was not functioning correctly, leading to inaccuracies in the changelog generation process. This update addresses those issues, ensuring more reliable and accurate output.
Rules for Determining Previous Tags
Normal Versions:
Release Candidates (RC) for Normal Versions:
Alpha Versions:
Release Candidates (RC) for Alpha Versions:
Major Version Releases:
Release Candidates (RC) for Major Versions:
Examples:
Normal Versions:
8.4.0
, the previous tag is8.3.0
.8.3.3
, the previous tag is8.3.2
.8.3.1
, the previous tag is8.3.0
.Release Candidates (RC) for Normal Versions:
8.4.0-rc1
, the previous tag is8.3.0
.8.4.0-rc2
, the previous tag is8.4.0-rc1
.Alpha Versions:
8.4.0-alpha1
, the previous tag is8.3.0
.8.4.2-alpha2
, the previous tag is8.4.2-alpha1
.Release Candidates (RC) for Alpha Versions:
8.4.0-alpha2-rc1
, the previous tag is8.4.0-alpha1
.8.4.0-alpha1-rc1
, the previous tag is8.3.0
.Major Version Releases:
9.0.0
, the previous tag is8.9.0
.9.1.0
, the previous tag is9.0.0
.Release Candidates (RC) for Major Versions:
9.0.0-rc1
, the previous tag is8.9.0
.Invalid Tag Format:
Incomplete Tag:
Test Results :