Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Align response-header-size options and bump it higher #2479

Open
jessesimpson36 opened this issue Oct 16, 2024 · 1 comment
Open
Labels
cycle/pre-release Tasks will be done in pre-release cycle kind/enhancement New feature or request

Comments

@jessesimpson36
Copy link
Contributor

jessesimpson36 commented Oct 16, 2024

Describe the use case:

It's been pretty common that we've heard of people running into issues when they try to log in, and the token in the response header is so large that it exceeds the max size of the buffer. There are application-side reasons that this can occur, such as a web component having a default value. But there is also the ingress-side configuration which often appears as a 500 without a stacktrace.

These configuration options should be unified, and we should make sure this option is sufficiently large.

Currently, the options for the ingress is

      nginx.ingress.kubernetes.io/proxy-buffer-size: '128k'

And the option for the web components is the default 8KB for Jetty:
https://docs.spring.io/spring-boot/appendix/application-properties/index.html#application-properties.server.server.jetty.max-http-response-header-size

server.jetty.max-http-response-header-size

The following should be the env variable representation:
SERVER_JETTY_MAX_HTTP_RESPONSE_HEADER_SIZE

However, it's important to note that Optimize sets this value explicitly and uses their own variable for it. I'll try to find a link to it.
https://github.com/camunda/camunda/blob/56febdfddd5cf8012b919d668ed889287255edc0/optimize/util/optimize-commons/src/main/resources/service-config.yaml#L130

CAMUNDA_OPTIMIZE_CONTAINER_MAX_RESPONSE_HEADER_SIZE_BYTES

Describe the enhancement/feature:

Desired outcome and acceptance tests:

@jessesimpson36 jessesimpson36 added the kind/enhancement New feature or request label Oct 16, 2024
@jonathanlukas
Copy link
Contributor

The env for optimize would be:

CAMUNDA_OPTIMIZE_CONTAINER_MAX_RESPONSE_HEADER_SIZE_BYTES = 32768

@aabouzaid aabouzaid added this to the 8.7 Release Cycle milestone Oct 21, 2024
@aabouzaid aabouzaid added the cycle/pre-release Tasks will be done in pre-release cycle label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cycle/pre-release Tasks will be done in pre-release cycle kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants