Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] improve error handling for external web-modeler DB #2371

Open
Tracked by #1
hamza-m-masood opened this issue Sep 23, 2024 · 0 comments
Open
Tracked by #1

[ISSUE] improve error handling for external web-modeler DB #2371

hamza-m-masood opened this issue Sep 23, 2024 · 0 comments
Labels
code-freeze-candidate Issue found during a code freeze that we aren't sure yet are eligible to work on during the code fz kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between platform/aws Issues related to AWS platform/gcp Issues related to GCP

Comments

@hamza-m-masood
Copy link
Contributor

hamza-m-masood commented Sep 23, 2024

Describe the issue:

If a password is not supplied through the values.yaml when connecting to an external postgres DB for web modeler rest API then you get the following error:

Error: INSTALLATION FAILED: 1 error occurred:
        * Deployment.apps "camunda-web-modeler-restapi" is invalid: spec.template.spec.containers[0].env[2].valueFrom.secretKeyRef.name: Invalid value: "": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Actual behavior:

Strange error is seen referencing an env var in an array

Expected behavior:

It would be better if a cleaner error could be given. Such as password must be provided for external DB
or if a password is not provided then the SPRING_DATASOURCE_PASSWORD env var in webmodeler rest API that references the password secret could be optional depending on if the password is provided or not.

How to reproduce:

values.yaml used:

webModeler:
  restapi:
    externalDatabase:
      url: "url-test"
      user: "web-modeler"
      password: ""
postgresql:
  enabled: false

Logs:

Environment:

Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

  • Platform:
  • Helm CLI version:
  • Chart version: alpha(8.6)
  • Values file:
@hamza-m-masood hamza-m-masood added kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between code-freeze-candidate Issue found during a code freeze that we aren't sure yet are eligible to work on during the code fz labels Sep 23, 2024
@github-actions github-actions bot added platform/aws Issues related to AWS platform/gcp Issues related to GCP labels Sep 23, 2024
@hamza-m-masood hamza-m-masood changed the title [ISSUE] <issue title> [ISSUE] improve error handling for external web-modeler DB Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-freeze-candidate Issue found during a code freeze that we aren't sure yet are eligible to work on during the code fz kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between platform/aws Issues related to AWS platform/gcp Issues related to GCP
Projects
None yet
Development

No branches or pull requests

1 participant