From e0f66d65a17cc0421fe1c2e49a64785a7a5e609e Mon Sep 17 00:00:00 2001
From: venetrius <gergely.juhasz@camunda.com>
Date: Fri, 1 Nov 2024 12:55:34 +0100
Subject: [PATCH 1/4] fix(webapps): activityIdIn filter returns all relevant
 instances

related to: #4757
---
 .../entity/HistoricProcessInstance.xml        |  15 ++-
 .../history/HistoricProcessInstanceTest.java  | 120 +++++++++++++-----
 2 files changed, 94 insertions(+), 41 deletions(-)

diff --git a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
index 45dd2cbe23e..614ef16a245 100644
--- a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
+++ b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
@@ -402,7 +402,7 @@
 
     <bind name="INC_JOIN" value="false" />
     <bind name="HAI_JOIN" value="false" />
-    <bind name="INCACT_JOIN" value="false" />
+    <bind name="RU_EXE_JOIN" value="false" />
     <bind name="JOIN_TYPE" value="'inner join'" />
 
     <foreach collection="queries" item="query">
@@ -419,7 +419,7 @@
       </if>
 
       <if test="query != null &amp;&amp; (query.activityIds != null and query.activityIds.length > 0)">
-        <bind name="INCACT_JOIN" value="true" />
+        <bind name="RU_EXE_JOIN" value="true" />
       </if>
     </foreach>
 
@@ -431,8 +431,8 @@
       ON HAI.PROC_INST_ID_ = SELF.ID_
     </if>
 
-    <if test="INCACT_JOIN">
-      LEFT JOIN ${prefix}ACT_HI_INCIDENT INCACT on SELF.PROC_INST_ID_ = INCACT.PROC_INST_ID_
+    <if test="RU_EXE_JOIN">
+      LEFT JOIN ${prefix}ACT_RU_EXECUTION REXE on SELF.PROC_INST_ID_ = REXE.PROC_INST_ID_
     </if>
 
     <!-- actual value conditions are checked in the WHERE part;
@@ -645,17 +645,20 @@
 
             <if test="query.activityIds != null and query.activityIds.length > 0">
               ${queryType} (
-                  (
+                (
                   HAI.END_TIME_ IS NULL
                   AND HAI.ACT_ID_ IN
                   <foreach item="activityId" index="index" collection="query.activityIds" open="(" separator="," close=")">
                     #{activityId}
                   </foreach>
-                  ) OR INCACT.ACTIVITY_ID_ IN
+                )
+                OR (
+                  REXE.ACT_ID_ IN
                   <foreach item="activityId" index="index" collection="query.activityIds" open="(" separator="," close=")">
                     #{activityId}
                   </foreach>
                 )
+              )
             </if>
 
             <if test="query.executedActivityIds != null and query.executedActivityIds.length > 0">
diff --git a/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java b/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
index a342a9ff0e7..95bacf62e48 100644
--- a/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
+++ b/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
@@ -1657,11 +1657,42 @@ public void testQueryByNonLeafActivityId() {
   @Test
   @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
   public void testQueryByAsyncBeforeActivityId() {
-    // For a historic instance when AsyncBefore is used the historic activity is only created when the execution is scheduled
-    // For process instances that have a token just before a AsyncBefore activity
-    //  In the runtimeInstanceQuery activityIdIn filter returns instances that are not scheduled yet
-    //  In historicInstanceQuery activityIdIn filter does not return instances that are not scheduled yet
+    // given
+    ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
+        .startEvent("start").camundaAsyncBefore()
+        .serviceTask("task").camundaAsyncBefore().camundaExpression("${true}")
+        .endEvent("end").camundaAsyncBefore()
+        .done()
+    );
+
+    // when
+    ProcessInstance instanceBeforeStart = runtimeService.startProcessInstanceById(testProcess.getId());
+    ProcessInstance instanceBeforeTask = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceBeforeTask);
+    ProcessInstance instanceBeforeEnd = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceBeforeEnd);
+    executeJobForProcessInstance(instanceBeforeEnd);
 
+    // then
+    HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
+    assertNotNull(historicQuery.singleResult());
+    ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
+    assertEquals(instanceBeforeStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
+    assertEquals(instanceBeforeTask.getId(), historicQuery.singleResult().getId());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
+    assertEquals(instanceBeforeTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
+    assertEquals(instanceBeforeEnd.getId(), historicQuery.singleResult().getId());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
+    assertEquals(instanceBeforeEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+  }
+
+  @Test
+  @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
+  public void testQueryByAsyncBeforeActivityIdWithScope() {
     // given
     ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
         .startEvent("start").camundaAsyncBefore()
@@ -1689,34 +1720,58 @@ public void testQueryByAsyncBeforeActivityId() {
 
     // then
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNull(historicQuery.singleResult());
+    assertNotNull(historicQuery.singleResult());
     ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
     assertEquals(instanceBeforeStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertReturnedProcessInstances(historicQuery, instanceBeforeTask);
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
-    assertEquals(instanceBeforeSubProcess.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertThat(historicQuery.list().stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
+        .containsExactlyInAnyOrder(instanceBeforeSubProcess.getId(), instanceBeforeTask.getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceBeforeTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceBeforeTask.getId(), historicQuery.singleResult().getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceBeforeEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceBeforeEnd.getId(), historicQuery.singleResult().getId());
   }
 
+
   @Test
   @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
   public void testQueryByAsyncAfterActivityId() {
-    // For a historic activity the end time is set after it is executed => the activity is not considered active anymore,
-    //    this is not changed if AsyncAfter is used
-    //    if the task is a subprocess end time will only be set after the subprocess is terminated
-    // For the runtime query the execution is still visible if AsyncAfter is used (I assume we delete the execution when scheduling next activity)
+    // given
+    ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
+        .startEvent("start").camundaAsyncAfter()
+        .serviceTask("task").camundaAsyncAfter().camundaExpression("${true}")
+        .endEvent("end").camundaAsyncAfter()
+        .done()
+    );
+
+    // when
+    ProcessInstance instanceAfterStart = runtimeService.startProcessInstanceById(testProcess.getId());
+    ProcessInstance instanceAfterTask = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceAfterTask);
+    ProcessInstance instanceAfterEnd = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceAfterEnd);
+    executeJobForProcessInstance(instanceAfterEnd);
+
+    // then
+    HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterStart.getId(), historicQuery.singleResult().getId());
 
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterTask.getId(), historicQuery.singleResult().getId());
+
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterEnd.getId(), historicQuery.singleResult().getId());
+  }
+
+  @Test
+  @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
+  public void testQueryByAsyncAfterActivityIdWithScope() {
     // given
     ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
         .startEvent("start").camundaAsyncAfter()
@@ -1743,24 +1798,18 @@ public void testQueryByAsyncAfterActivityId() {
     executeJobForProcessInstance(instanceAfterEnd);
 
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNull(historicQuery.singleResult());
-    ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
-    assertEquals(instanceAfterStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterStart.getId(), historicQuery.singleResult().getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceAfterTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceAfterTask.getId(), historicQuery.singleResult().getId());
 
-    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertReturnedProcessInstances(historicQuery, instanceAfterTask);
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
-    assertEquals(instanceAfterSubProcess.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess"); // 12 (instanceAfterTask), 23
+    assertThat(historicQuery.list().stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
+        .containsExactlyInAnyOrder(instanceAfterSubProcess.getId(),instanceAfterTask.getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceAfterEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceAfterEnd.getId(), historicQuery.singleResult().getId());
   }
 
   @Test
@@ -1794,7 +1843,7 @@ public void testQueryByActivityIdDuringCompensation() {
 
     // then
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertNull(historicQuery.singleResult());
+    assertNotNull(historicQuery.singleResult());
     ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
     assertEquals(processInstance.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
@@ -1906,7 +1955,7 @@ public void testHistoricProcInstQueryWithActivityIdsWithFailingActivity() {
     runtimeService.startProcessInstanceByKey("failingProcess");
     testHelper.executeAvailableJobs();
 
-    runtimeService.startProcessInstanceByKey("failingProcess");
+    ProcessInstance processInstanceInWait = runtimeService.startProcessInstanceByKey("failingProcess");
 
     // assume
     assertEquals(2, historyService.createHistoricProcessInstanceQuery().count());
@@ -1924,8 +1973,9 @@ public void testHistoricProcInstQueryWithActivityIdsWithFailingActivity() {
 
     // then
     assertNotNull(result);
-    assertEquals(1, result.size());
-    assertEquals(result.get(0).getId(), failingInstance.getId());
+    assertEquals(2, result.size());
+    assertThat(result.stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
+        .containsExactlyInAnyOrder(failingInstance.getId(), processInstanceInWait.getId());
   }
 
   @Test

From 3c7f9929bb8e0216cb4061fd520c30ec1028db05 Mon Sep 17 00:00:00 2001
From: venetrius <gergely.juhasz@camunda.com>
Date: Sun, 3 Nov 2024 15:07:13 +0100
Subject: [PATCH 2/4] Revert "fix(webapps): activityIdIn filter returns all
 relevant instances"

This reverts commit e0f66d65a17cc0421fe1c2e49a64785a7a5e609e.
---
 .../entity/HistoricProcessInstance.xml        |  15 +--
 .../history/HistoricProcessInstanceTest.java  | 120 +++++-------------
 2 files changed, 41 insertions(+), 94 deletions(-)

diff --git a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
index 614ef16a245..45dd2cbe23e 100644
--- a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
+++ b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
@@ -402,7 +402,7 @@
 
     <bind name="INC_JOIN" value="false" />
     <bind name="HAI_JOIN" value="false" />
-    <bind name="RU_EXE_JOIN" value="false" />
+    <bind name="INCACT_JOIN" value="false" />
     <bind name="JOIN_TYPE" value="'inner join'" />
 
     <foreach collection="queries" item="query">
@@ -419,7 +419,7 @@
       </if>
 
       <if test="query != null &amp;&amp; (query.activityIds != null and query.activityIds.length > 0)">
-        <bind name="RU_EXE_JOIN" value="true" />
+        <bind name="INCACT_JOIN" value="true" />
       </if>
     </foreach>
 
@@ -431,8 +431,8 @@
       ON HAI.PROC_INST_ID_ = SELF.ID_
     </if>
 
-    <if test="RU_EXE_JOIN">
-      LEFT JOIN ${prefix}ACT_RU_EXECUTION REXE on SELF.PROC_INST_ID_ = REXE.PROC_INST_ID_
+    <if test="INCACT_JOIN">
+      LEFT JOIN ${prefix}ACT_HI_INCIDENT INCACT on SELF.PROC_INST_ID_ = INCACT.PROC_INST_ID_
     </if>
 
     <!-- actual value conditions are checked in the WHERE part;
@@ -645,20 +645,17 @@
 
             <if test="query.activityIds != null and query.activityIds.length > 0">
               ${queryType} (
-                (
+                  (
                   HAI.END_TIME_ IS NULL
                   AND HAI.ACT_ID_ IN
                   <foreach item="activityId" index="index" collection="query.activityIds" open="(" separator="," close=")">
                     #{activityId}
                   </foreach>
-                )
-                OR (
-                  REXE.ACT_ID_ IN
+                  ) OR INCACT.ACTIVITY_ID_ IN
                   <foreach item="activityId" index="index" collection="query.activityIds" open="(" separator="," close=")">
                     #{activityId}
                   </foreach>
                 )
-              )
             </if>
 
             <if test="query.executedActivityIds != null and query.executedActivityIds.length > 0">
diff --git a/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java b/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
index 95bacf62e48..a342a9ff0e7 100644
--- a/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
+++ b/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
@@ -1657,42 +1657,11 @@ public void testQueryByNonLeafActivityId() {
   @Test
   @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
   public void testQueryByAsyncBeforeActivityId() {
-    // given
-    ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
-        .startEvent("start").camundaAsyncBefore()
-        .serviceTask("task").camundaAsyncBefore().camundaExpression("${true}")
-        .endEvent("end").camundaAsyncBefore()
-        .done()
-    );
-
-    // when
-    ProcessInstance instanceBeforeStart = runtimeService.startProcessInstanceById(testProcess.getId());
-    ProcessInstance instanceBeforeTask = runtimeService.startProcessInstanceById(testProcess.getId());
-    executeJobForProcessInstance(instanceBeforeTask);
-    ProcessInstance instanceBeforeEnd = runtimeService.startProcessInstanceById(testProcess.getId());
-    executeJobForProcessInstance(instanceBeforeEnd);
-    executeJobForProcessInstance(instanceBeforeEnd);
+    // For a historic instance when AsyncBefore is used the historic activity is only created when the execution is scheduled
+    // For process instances that have a token just before a AsyncBefore activity
+    //  In the runtimeInstanceQuery activityIdIn filter returns instances that are not scheduled yet
+    //  In historicInstanceQuery activityIdIn filter does not return instances that are not scheduled yet
 
-    // then
-    HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNotNull(historicQuery.singleResult());
-    ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
-    assertEquals(instanceBeforeStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
-
-    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceBeforeTask.getId(), historicQuery.singleResult().getId());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceBeforeTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
-
-    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceBeforeEnd.getId(), historicQuery.singleResult().getId());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceBeforeEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
-  }
-
-  @Test
-  @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
-  public void testQueryByAsyncBeforeActivityIdWithScope() {
     // given
     ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
         .startEvent("start").camundaAsyncBefore()
@@ -1720,58 +1689,34 @@ public void testQueryByAsyncBeforeActivityIdWithScope() {
 
     // then
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNotNull(historicQuery.singleResult());
+    assertNull(historicQuery.singleResult());
     ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
     assertEquals(instanceBeforeStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertThat(historicQuery.list().stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
-        .containsExactlyInAnyOrder(instanceBeforeSubProcess.getId(), instanceBeforeTask.getId());
+    assertReturnedProcessInstances(historicQuery, instanceBeforeTask);
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
+    assertEquals(instanceBeforeSubProcess.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceBeforeTask.getId(), historicQuery.singleResult().getId());
+    assertNull(historicQuery.singleResult());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
+    assertEquals(instanceBeforeTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceBeforeEnd.getId(), historicQuery.singleResult().getId());
+    assertNull(historicQuery.singleResult());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
+    assertEquals(instanceBeforeEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
   }
 
-
   @Test
   @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
   public void testQueryByAsyncAfterActivityId() {
-    // given
-    ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
-        .startEvent("start").camundaAsyncAfter()
-        .serviceTask("task").camundaAsyncAfter().camundaExpression("${true}")
-        .endEvent("end").camundaAsyncAfter()
-        .done()
-    );
-
-    // when
-    ProcessInstance instanceAfterStart = runtimeService.startProcessInstanceById(testProcess.getId());
-    ProcessInstance instanceAfterTask = runtimeService.startProcessInstanceById(testProcess.getId());
-    executeJobForProcessInstance(instanceAfterTask);
-    ProcessInstance instanceAfterEnd = runtimeService.startProcessInstanceById(testProcess.getId());
-    executeJobForProcessInstance(instanceAfterEnd);
-    executeJobForProcessInstance(instanceAfterEnd);
-
-    // then
-    HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNotNull(historicQuery.singleResult());
-    assertEquals(instanceAfterStart.getId(), historicQuery.singleResult().getId());
+    // For a historic activity the end time is set after it is executed => the activity is not considered active anymore,
+    //    this is not changed if AsyncAfter is used
+    //    if the task is a subprocess end time will only be set after the subprocess is terminated
+    // For the runtime query the execution is still visible if AsyncAfter is used (I assume we delete the execution when scheduling next activity)
 
-    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertNotNull(historicQuery.singleResult());
-    assertEquals(instanceAfterTask.getId(), historicQuery.singleResult().getId());
-
-    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertNotNull(historicQuery.singleResult());
-    assertEquals(instanceAfterEnd.getId(), historicQuery.singleResult().getId());
-  }
-
-  @Test
-  @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
-  public void testQueryByAsyncAfterActivityIdWithScope() {
     // given
     ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
         .startEvent("start").camundaAsyncAfter()
@@ -1798,18 +1743,24 @@ public void testQueryByAsyncAfterActivityIdWithScope() {
     executeJobForProcessInstance(instanceAfterEnd);
 
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNotNull(historicQuery.singleResult());
-    assertEquals(instanceAfterStart.getId(), historicQuery.singleResult().getId());
+    assertNull(historicQuery.singleResult());
+    ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
+    assertEquals(instanceAfterStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceAfterTask.getId(), historicQuery.singleResult().getId());
+    assertNull(historicQuery.singleResult());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
+    assertEquals(instanceAfterTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
-    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess"); // 12 (instanceAfterTask), 23
-    assertThat(historicQuery.list().stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
-        .containsExactlyInAnyOrder(instanceAfterSubProcess.getId(),instanceAfterTask.getId());
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
+    assertReturnedProcessInstances(historicQuery, instanceAfterTask);
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
+    assertEquals(instanceAfterSubProcess.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceAfterEnd.getId(), historicQuery.singleResult().getId());
+    assertNull(historicQuery.singleResult());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
+    assertEquals(instanceAfterEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
   }
 
   @Test
@@ -1843,7 +1794,7 @@ public void testQueryByActivityIdDuringCompensation() {
 
     // then
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertNotNull(historicQuery.singleResult());
+    assertNull(historicQuery.singleResult());
     ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
     assertEquals(processInstance.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
@@ -1955,7 +1906,7 @@ public void testHistoricProcInstQueryWithActivityIdsWithFailingActivity() {
     runtimeService.startProcessInstanceByKey("failingProcess");
     testHelper.executeAvailableJobs();
 
-    ProcessInstance processInstanceInWait = runtimeService.startProcessInstanceByKey("failingProcess");
+    runtimeService.startProcessInstanceByKey("failingProcess");
 
     // assume
     assertEquals(2, historyService.createHistoricProcessInstanceQuery().count());
@@ -1973,9 +1924,8 @@ public void testHistoricProcInstQueryWithActivityIdsWithFailingActivity() {
 
     // then
     assertNotNull(result);
-    assertEquals(2, result.size());
-    assertThat(result.stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
-        .containsExactlyInAnyOrder(failingInstance.getId(), processInstanceInWait.getId());
+    assertEquals(1, result.size());
+    assertEquals(result.get(0).getId(), failingInstance.getId());
   }
 
   @Test

From cfd321211c0887a07b70ed82a2d1c9f465e1ca48 Mon Sep 17 00:00:00 2001
From: venetrius <gergely.juhasz@camunda.com>
Date: Sun, 3 Nov 2024 15:08:07 +0100
Subject: [PATCH 3/4] fix(webapps): activityIdIn filter returns all relevant
 instances related to: #4757

---
 .../entity/HistoricProcessInstance.xml        |  21 ++-
 .../history/HistoricProcessInstanceTest.java  | 139 ++++++++++++------
 2 files changed, 110 insertions(+), 50 deletions(-)

diff --git a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
index 45dd2cbe23e..8cdbc3e03f8 100644
--- a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
+++ b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
@@ -402,8 +402,10 @@
 
     <bind name="INC_JOIN" value="false" />
     <bind name="HAI_JOIN" value="false" />
-    <bind name="INCACT_JOIN" value="false" />
+    <bind name="RU_EXE_JOIN" value="false" />
     <bind name="JOIN_TYPE" value="'inner join'" />
+    <bind name="INCACT_JOIN" value="false" />
+
 
     <foreach collection="queries" item="query">
       <if test="query.isOrQueryActive">
@@ -420,6 +422,7 @@
 
       <if test="query != null &amp;&amp; (query.activityIds != null and query.activityIds.length > 0)">
         <bind name="INCACT_JOIN" value="true" />
+        <bind name="RU_EXE_JOIN" value="true" />
       </if>
     </foreach>
 
@@ -435,6 +438,12 @@
       LEFT JOIN ${prefix}ACT_HI_INCIDENT INCACT on SELF.PROC_INST_ID_ = INCACT.PROC_INST_ID_
     </if>
 
+    <if test="RU_EXE_JOIN">
+      LEFT JOIN ${prefix}ACT_RU_EXECUTION REXE on SELF.PROC_INST_ID_ = REXE.PROC_INST_ID_
+    </if>
+
+
+
     <!-- actual value conditions are checked in the WHERE part;
        however here we must join once for every variable condition.
        It is important that in the WHERE part we use the same table
@@ -645,17 +654,19 @@
 
             <if test="query.activityIds != null and query.activityIds.length > 0">
               ${queryType} (
-                  (
-                  HAI.END_TIME_ IS NULL
-                  AND HAI.ACT_ID_ IN
+                (
+                  INCACT.ACTIVITY_ID_ IN
                   <foreach item="activityId" index="index" collection="query.activityIds" open="(" separator="," close=")">
                     #{activityId}
                   </foreach>
-                  ) OR INCACT.ACTIVITY_ID_ IN
+                )
+                OR (
+                  REXE.ACT_ID_ IN
                   <foreach item="activityId" index="index" collection="query.activityIds" open="(" separator="," close=")">
                     #{activityId}
                   </foreach>
                 )
+              )
             </if>
 
             <if test="query.executedActivityIds != null and query.executedActivityIds.length > 0">
diff --git a/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java b/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
index a342a9ff0e7..1ef9a679b23 100644
--- a/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
+++ b/engine/src/test/java/org/camunda/bpm/engine/test/history/HistoricProcessInstanceTest.java
@@ -1657,11 +1657,42 @@ public void testQueryByNonLeafActivityId() {
   @Test
   @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
   public void testQueryByAsyncBeforeActivityId() {
-    // For a historic instance when AsyncBefore is used the historic activity is only created when the execution is scheduled
-    // For process instances that have a token just before a AsyncBefore activity
-    //  In the runtimeInstanceQuery activityIdIn filter returns instances that are not scheduled yet
-    //  In historicInstanceQuery activityIdIn filter does not return instances that are not scheduled yet
+    // given
+    ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
+        .startEvent("start").camundaAsyncBefore()
+        .serviceTask("task").camundaAsyncBefore().camundaExpression("${true}")
+        .endEvent("end").camundaAsyncBefore()
+        .done()
+    );
+
+    // when
+    ProcessInstance instanceBeforeStart = runtimeService.startProcessInstanceById(testProcess.getId());
+    ProcessInstance instanceBeforeTask = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceBeforeTask);
+    ProcessInstance instanceBeforeEnd = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceBeforeEnd);
+    executeJobForProcessInstance(instanceBeforeEnd);
+
+    // then
+    HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
+    assertNotNull(historicQuery.singleResult());
+    ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
+    assertEquals(instanceBeforeStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
+    assertEquals(instanceBeforeTask.getId(), historicQuery.singleResult().getId());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
+    assertEquals(instanceBeforeTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
+    assertEquals(instanceBeforeEnd.getId(), historicQuery.singleResult().getId());
+    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
+    assertEquals(instanceBeforeEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+  }
 
+  @Test
+  @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
+  public void testQueryByAsyncBeforeActivityIdWithScope() {
     // given
     ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
         .startEvent("start").camundaAsyncBefore()
@@ -1689,34 +1720,58 @@ public void testQueryByAsyncBeforeActivityId() {
 
     // then
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNull(historicQuery.singleResult());
+    assertNotNull(historicQuery.singleResult());
     ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
     assertEquals(instanceBeforeStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertReturnedProcessInstances(historicQuery, instanceBeforeTask);
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
-    assertEquals(instanceBeforeSubProcess.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertThat(historicQuery.list().stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
+        .containsExactlyInAnyOrder(instanceBeforeSubProcess.getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceBeforeTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceBeforeTask.getId(), historicQuery.singleResult().getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceBeforeEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceBeforeEnd.getId(), historicQuery.singleResult().getId());
   }
 
+
   @Test
   @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
   public void testQueryByAsyncAfterActivityId() {
-    // For a historic activity the end time is set after it is executed => the activity is not considered active anymore,
-    //    this is not changed if AsyncAfter is used
-    //    if the task is a subprocess end time will only be set after the subprocess is terminated
-    // For the runtime query the execution is still visible if AsyncAfter is used (I assume we delete the execution when scheduling next activity)
+    // given
+    ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
+        .startEvent("start").camundaAsyncAfter()
+        .serviceTask("task").camundaAsyncAfter().camundaExpression("${true}")
+        .endEvent("end").camundaAsyncAfter()
+        .done()
+    );
+
+    // when
+    ProcessInstance instanceAfterStart = runtimeService.startProcessInstanceById(testProcess.getId());
+    ProcessInstance instanceAfterTask = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceAfterTask);
+    ProcessInstance instanceAfterEnd = runtimeService.startProcessInstanceById(testProcess.getId());
+    executeJobForProcessInstance(instanceAfterEnd);
+    executeJobForProcessInstance(instanceAfterEnd);
+
+    // then
+    HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterStart.getId(), historicQuery.singleResult().getId());
+
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterTask.getId(), historicQuery.singleResult().getId());
+
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterEnd.getId(), historicQuery.singleResult().getId());
+  }
 
+  @Test
+  @RequiredHistoryLevel(ProcessEngineConfiguration.HISTORY_FULL)
+  public void testQueryByAsyncAfterActivityIdWithScope() {
     // given
     ProcessDefinition testProcess = testHelper.deployAndGetDefinition(ProcessModels.newModel()
         .startEvent("start").camundaAsyncAfter()
@@ -1743,24 +1798,18 @@ public void testQueryByAsyncAfterActivityId() {
     executeJobForProcessInstance(instanceAfterEnd);
 
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("start");
-    assertNull(historicQuery.singleResult());
-    ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("start");
-    assertEquals(instanceAfterStart.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertNotNull(historicQuery.singleResult());
+    assertEquals(instanceAfterStart.getId(), historicQuery.singleResult().getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("task");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("task");
-    assertEquals(instanceAfterTask.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceAfterTask.getId(), historicQuery.singleResult().getId());
 
-    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertReturnedProcessInstances(historicQuery, instanceAfterTask);
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
-    assertEquals(instanceAfterSubProcess.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess"); // 12 (instanceAfterTask), 23
+    assertThat(historicQuery.list().stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
+        .containsExactlyInAnyOrder(instanceAfterSubProcess.getId());
 
     historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("end");
-    assertNull(historicQuery.singleResult());
-    runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("end");
-    assertEquals(instanceAfterEnd.getId(), runtimeQuery.singleResult().getProcessInstanceId());
+    assertEquals(instanceAfterEnd.getId(), historicQuery.singleResult().getId());
   }
 
   @Test
@@ -1794,7 +1843,7 @@ public void testQueryByActivityIdDuringCompensation() {
 
     // then
     HistoricProcessInstanceQuery historicQuery = historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess");
-    assertNull(historicQuery.singleResult());
+    assertNotNull(historicQuery.singleResult());
     ProcessInstanceQuery runtimeQuery = runtimeService.createProcessInstanceQuery().activityIdIn("subProcess");
     assertEquals(processInstance.getId(), runtimeQuery.singleResult().getProcessInstanceId());
 
@@ -1906,7 +1955,7 @@ public void testHistoricProcInstQueryWithActivityIdsWithFailingActivity() {
     runtimeService.startProcessInstanceByKey("failingProcess");
     testHelper.executeAvailableJobs();
 
-    runtimeService.startProcessInstanceByKey("failingProcess");
+    ProcessInstance processInstanceInWait = runtimeService.startProcessInstanceByKey("failingProcess");
 
     // assume
     assertEquals(2, historyService.createHistoricProcessInstanceQuery().count());
@@ -1924,8 +1973,9 @@ public void testHistoricProcInstQueryWithActivityIdsWithFailingActivity() {
 
     // then
     assertNotNull(result);
-    assertEquals(1, result.size());
-    assertEquals(result.get(0).getId(), failingInstance.getId());
+    assertEquals(2, result.size());
+    assertThat(result.stream().map(HistoricProcessInstance::getId).collect(Collectors.toList()))
+        .containsExactlyInAnyOrder(failingInstance.getId(), processInstanceInWait.getId());
   }
 
   @Test
@@ -1939,7 +1989,7 @@ public void shouldQueryByActivityIdInWithActivityIdOfFailingSubprocess() {
 
     // when
     HistoricProcessInstance historicPI =
-        historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess").singleResult();
+        historyService.createHistoricProcessInstanceQuery().activityIdIn("serviceTask").singleResult();
 
     // then
     assertThat(historicPI).isNotNull();
@@ -1977,7 +2027,7 @@ public void shouldQueryByActivityIdInWithActivityIdOfSubprocess() {
     taskService.complete(task.getId());
     // when
     HistoricProcessInstance historicPI =
-        historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess").singleResult();
+        historyService.createHistoricProcessInstanceQuery().activityIdIn("innerTask").singleResult();
 
     // then
     assertThat(historicPI).isNotNull();
@@ -2021,8 +2071,8 @@ public void shouldQueryByActivityIdInWithMultipleScopeAndIncident() {
     // when
     List<HistoricProcessInstance> queryByInnerServiceActivityId =
         historyService.createHistoricProcessInstanceQuery().activityIdIn("innerServiceTask").list();
-    List<HistoricProcessInstance>  queryBySubProcessActivityId =
-        historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess").list();
+    HistoricProcessInstance  queryBySubProcessActivityId =
+        historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess").singleResult();
     List<HistoricProcessInstance>  queryByOuterProcessActivityId =
         historyService.createHistoricProcessInstanceQuery().activityIdIn("outerTask").list();
     List<HistoricProcessInstance> queryByOuterAndInnedActivityId =
@@ -2032,8 +2082,8 @@ public void shouldQueryByActivityIdInWithMultipleScopeAndIncident() {
     assertThat(queryByInnerServiceActivityId.size()).isEqualTo(1);
     assertThat(queryByInnerServiceActivityId.get(0).getId()).isEqualTo(processInstance.getId());
 
-    assertThat(queryBySubProcessActivityId.size()).isEqualTo(1);
-    assertThat(queryBySubProcessActivityId.get(0).getId()).isEqualTo(processInstance.getId());
+    assertNull(queryBySubProcessActivityId);
+
 
     assertThat(queryByOuterProcessActivityId.size()).isEqualTo(1);
     assertThat(queryByOuterProcessActivityId.get(0).getId()).isEqualTo(processInstance2.getId());
@@ -2060,8 +2110,8 @@ public void shouldQueryByActivityIdInWithMultipleScope() {
     // when
     List<HistoricProcessInstance> queryByInnerServiceActivityId =
         historyService.createHistoricProcessInstanceQuery().activityIdIn("innerTask").list();
-    List<HistoricProcessInstance>  queryBySubProcessActivityId =
-        historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess").list();
+    HistoricProcessInstance  queryBySubProcessActivityId =
+        historyService.createHistoricProcessInstanceQuery().activityIdIn("subProcess").singleResult();
     List<HistoricProcessInstance>  queryByOuterProcessActivityId =
         historyService.createHistoricProcessInstanceQuery().activityIdIn("outerTask").list();
     List<HistoricProcessInstance> queryByOuterAndInnedActivityId =
@@ -2071,8 +2121,7 @@ public void shouldQueryByActivityIdInWithMultipleScope() {
     assertThat(queryByInnerServiceActivityId.size()).isEqualTo(1);
     assertThat(queryByInnerServiceActivityId.get(0).getId()).isEqualTo(processInstance.getId());
 
-    assertThat(queryBySubProcessActivityId.size()).isEqualTo(1);
-    assertThat(queryBySubProcessActivityId.get(0).getId()).isEqualTo(processInstance.getId());
+    assertNull(queryBySubProcessActivityId);
 
     assertThat(queryByOuterProcessActivityId.size()).isEqualTo(1);
     assertThat(queryByOuterProcessActivityId.get(0).getId()).isEqualTo(processInstance2.getId());

From dc01871aed868e336936e6e432aa824cc9f061ac Mon Sep 17 00:00:00 2001
From: venetrius <gergely.juhasz@camunda.com>
Date: Mon, 4 Nov 2024 08:28:16 +0100
Subject: [PATCH 4/4] don't HAI_JOIN when activityIds present

---
 .../bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
index 8cdbc3e03f8..bff844d41c1 100644
--- a/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
+++ b/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricProcessInstance.xml
@@ -416,7 +416,7 @@
         <bind name="INC_JOIN" value="true" />
       </if>
 
-      <if test="query != null &amp;&amp; (query.executedActivityIds != null and query.executedActivityIds.length > 0) || (query.activeActivityIds != null and query.activeActivityIds.length > 0) || (query.activityIds != null and query.activityIds.length > 0)">
+      <if test="query != null &amp;&amp; (query.executedActivityIds != null and query.executedActivityIds.length > 0) || (query.activeActivityIds != null and query.activeActivityIds.length > 0)">
         <bind name="HAI_JOIN" value="true" />
       </if>