Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(tomcat10): restore engine integration tests #4491

Merged
merged 1 commit into from
Jul 24, 2024
Merged

test(tomcat10): restore engine integration tests #4491

merged 1 commit into from
Jul 24, 2024

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Jul 18, 2024

related to #4434

@tasso94 tasso94 added the ci:all-as Runs the builds for all application servers. label Jul 18, 2024
@tasso94 tasso94 requested a review from psavidis July 18, 2024 22:50
@tasso94 tasso94 self-assigned this Jul 18, 2024
@tasso94 tasso94 mentioned this pull request Jul 18, 2024
Closed
@psavidis psavidis force-pushed the 4434-restore-tomcat-10-engine-its branch from f30af60 to 2cf391e Compare July 24, 2024 07:30
@psavidis
Copy link
Contributor

The first build has already passed which includes the fix for all tests but the last 2 which remain unfixed.

Moving on with the merge

@psavidis psavidis merged commit b48a2e3 into master Jul 24, 2024
3 of 5 checks passed
@psavidis psavidis deleted the 4434-restore-tomcat-10-engine-its branch July 24, 2024 07:41
@danielkelemen
Copy link
Member

❓ @psavidis EE CI run seemed still quite broken. What is the plan with that?

@psavidis
Copy link
Contributor

Thanks Daniel, since this PR was merged, i will open a new one to handle the EE Test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavidis psavidis psavidis approved these changes

Assignees

@tasso94 tasso94

Labels
ci:all-as Runs the builds for all application servers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tasso94 @psavidis @danielkelemen