Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | Improve the Existing Implementation #4789

Open
Tracked by #4165
psavidis opened this issue Nov 13, 2024 · 2 comments
Open
Tracked by #4165

Refactor | Improve the Existing Implementation #4789

psavidis opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@psavidis
Copy link
Contributor

psavidis commented Nov 13, 2024

Acceptance Criteria (Required on creation)

  • The existing solution for Multi-image support and Running Postgres 17 using Podspecs is improved / refactored

Hints

  • Review feedback
  • Any Brainstorming Ideas for improvement

Links

@psavidis psavidis mentioned this issue Nov 13, 2024
7 tasks
@psavidis psavidis self-assigned this Nov 13, 2024
@psavidis
Copy link
Contributor Author

psavidis commented Nov 13, 2024

Improvement Ideas

Code Review Points

  • A. Scepticism on db and execution node inference
    • The detection of executionNode images at the moment works for maven and alpine images
    • Link
  • B. The execution of db images at the moment executes postgres in a hardcoded way without considering any conditionals
  • C. The h2 conditional of the podSpecIsCalledWithAgentLabel branch was not clear to the reviewer (despite the comment)
    • It could be an indication that the code needs to be simplified
    • Link

@psavidis
Copy link
Contributor Author

Document with Improvement Ideas can be found here

Next step: Use the document to collaborate / decide on concrete ideas for improvement; calculate the breakdown and split it into individual assignable tasks which can be added under this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant