Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No description displaying when hover over on the outlier instance on the details modal for Task Analysis #4774

Open
1 task done
venetrius opened this issue Nov 7, 2024 · 4 comments
Open
1 task done

No description displaying when hover over on the outlier instance on the details modal for Task Analysis #4774

venetrius opened this issue Nov 7, 2024 · 4 comments
Assignees
@RobertDorlan
Labels
scope:optimize Changes to Optimize. type:bug Issues that describe a user-facing bug in the project. version:optimize 3.15.0

Comments

@venetrius
Copy link
Member

venetrius commented Nov 7, 2024 •
edited
Loading

Environment (Required on creation)

Optimize version : Tested in Tested on Branch --> [6849-entitylist-carbonization]

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

No description displaying when hoover over on the outlier instance

Steps to reproduce (Required on creation)

  1. Login into Optimize app
  2. Select Analysis tab
  3. Select a process (e.g "Camunda Customer Onboarding Demo")
  4. On the bottom an Outliers table is displayed
  5. select View details on the second flow node ( Check application automatically) a
  6. Hoover over the first grey outlier

Observed Behavior (Required on creation)

image
Screen.Recording.2024-03-19.at.13.42.26.mov

Expected behavior (Required on creation)

A popup is displayed with description of instances about how long they took

Root Cause (Required on prioritization)

  • When the number of occurrences are higher then 1000, the format of the value for a tooltip is 1,000
  • The logic that filters out tooltips for 0 occurrences: +tooltipItem.formattedValue > 0
  • +"2,000" is evaluated as NaN, NaN > 0 is evaluated as false

Solution Ideas

Hints

Links

https://github.com/camunda/camunda-optimize/issues/12212

Breakdown

Pull Requests
Beta Give feedback

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@venetrius venetrius added type:bug Issues that describe a user-facing bug in the project. scope:ci Changes to the CI, e.g. Jenkins pipelines. version:optimize 3.15.0 labels Nov 7, 2024
@venetrius venetrius self-assigned this Nov 7, 2024
@venetrius
Copy link
Member Author

I was not able to reproduce this behaviour following the steps outlined.
See screen shot:

Screen shots

Process with outliers
ProcessWith2Outlier

Tooltip is present in the first modal
FirstRendersOK

Tooltip is present in the second modal

SecondRenderOk

Branch 6849-entitylist-carbonization does not exist anymore.

@RobertDorlan
Copy link

Hey @venetrius I was able to reproduce it
Tested agains C7- 3.15.0-SNAPSHOT

What you can do to reproduce it is try with the Camunda Customer Onboarding data set

Screen.Recording.2024-11-07.at.17.02.44.mov

@venetrius
Copy link
Member Author

updated Root Cause

@venetrius venetrius added scope:optimize Changes to Optimize. and removed scope:ci Changes to the CI, e.g. Jenkins pipelines. labels Nov 12, 2024
OmranAbazid added a commit to camunda/camunda that referenced this issue Nov 13, 2024
@OmranAbazid
fix(client): show durationChart tooltip for large numbers
ec5740d 
related to camunda/camunda-bpm-platform/issues/4774
@OmranAbazid OmranAbazid mentioned this issue Nov 13, 2024
Merged
3 tasks
OmranAbazid added a commit to camunda/camunda that referenced this issue Nov 15, 2024
@OmranAbazid
fix: show durationChart tooltip for large numbers
1e6606d 
related to camunda/camunda-bpm-platform/issues/4774
github-merge-queue bot pushed a commit to camunda/camunda that referenced this issue Nov 15, 2024
@OmranAbazid
fix(client): show durationChart tooltip for large numbers (#24684)
ca19873 
## Description

<!-- Describe the goal and purpose of this PR. -->

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] for CI changes:
- [ ] structural/foundational changes signed off by [CI
DRI](https://github.com/cmur2)
- [ ]
[ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml)
modifications comply with ["Unified CI"
requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria)

## Related issues

related to camunda/camunda-bpm-platform/issues/4774
@venetrius venetrius reopened this Nov 18, 2024
@tasso94 tasso94 assigned RobertDorlan and unassigned venetrius Nov 18, 2024
kzraitel pushed a commit to camunda/camunda that referenced this issue Nov 18, 2024
@OmranAbazid @kzraitel
fix: show durationChart tooltip for large numbers
2118c29 
related to camunda/camunda-bpm-platform/issues/4774
@RobertDorlan
Copy link

Successfully tested agains C7-3.15.0-SNAPSHOT

A popup is displayed with description of instances about how long they took works as expected

Screen.Recording.2024-11-20.at.20.03.56.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertDorlan RobertDorlan

Labels
scope:optimize Changes to Optimize. type:bug Issues that describe a user-facing bug in the project. version:optimize 3.15.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@venetrius @RobertDorlan