Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releaseTrunc value is no longer accepted at root level #239

Open
AlexGacon opened this issue Sep 3, 2024 · 7 comments
Open

releaseTrunc value is no longer accepted at root level #239

AlexGacon opened this issue Sep 3, 2024 · 7 comments
Assignees

Comments

@AlexGacon
Copy link
Contributor

Hello. I am trying to update nexsis deployment to helm chart 2.1.2 (from 0.9.1) and I have regressions:

The releaseTrunc value below the geoserver: entry is no longer accepted. If I remove it, I have ConfigMap conflicts between different environments

The affinity part of the deployment is going wrong. In debug mode, I end up with something like:

      nodeSelector:
        node.kubernetes.io/role: sigaffinity:
        podAntiAffinity:

My inputs are:

-- default values.yaml
  additional-stuff: &additional-stuff
    releaseTrunc: 60
    nodeSelector:
      node.kubernetes.io/role: sig

and

-- generated for a given environment
        affinity:
          podAntiAffinity:
            preferredDuringSchedulingIgnoredDuringExecution:
              - podAffinityTerm:
                  labelSelector:
                    matchExpressions:
                      - key: app
                        operator: In
                        values:
                          - geoserver
                  topologyKey: failure-domain.beta.kubernetes.io/zone
                weight: 100
              - podAffinityTerm:
                  labelSelector:
                    matchExpressions:
                      - key: app
                        operator: In
                        values:
                          - geoserver
                  topologyKey: kubernetes.io/hostname
                weight: 99
@AlexGacon
Copy link
Contributor Author

`geoservercloud:
global: *global

additional-stuff: &additional-stuff
releaseTrunc: 60
nodeSelector:
node.kubernetes.io/role: sig

geoserver:

releaseTrunc: 60

`

@AlexGacon
Copy link
Contributor Author

For the releaseTrunc stuff, breaking change has been introduced with 2.0.0 which introduces custom-pod 2.0.2

@sbrunner
Copy link
Member

sbrunner commented Sep 3, 2024

After reading the code again, the releaseTrunc at root level didn't look to do anything.

In fact, the code is not trivial, then I can miss something, then which object is modified if you change only the releaseTrunc at root level?

@sbrunner
Copy link
Member

sbrunner commented Sep 3, 2024

You speak about ConfigMap conflicts but which one? The config map metadata?

@AlexGacon
Copy link
Contributor Author

@sbrunner we already discussed it some months ago on Slack (see https://camptocamp.slack.com/archives/CU8MW1B9S/p1710403648314149).

@sbrunner
Copy link
Member

This is about such an old version it probably changed.

@AlexGacon
Copy link
Contributor Author

March is only 6 months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants